Issue 1831001: Fixes to address code review comments from tommi from CL http://codereview.ch...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1831001: Fixes to address code review comments from tommi from CL http://codereview.ch... (Closed)

Created:
10 years, 7 months ago by ananta

Modified:
9 years, 6 months ago

Reviewers:
tommi (sloooow) - chröme

CC:
chromium-reviews, amit

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Fixes to address code review comments from tommi from CL http://codereview.chromium.org/1823001/show Changes include the following:- 1. Removing the IObjectWithSite::SetSite implementation from the chrome frame activex. 2. Removing the site_ member and using the ATL m_spUnkSite member. 3. Renaming the RegisterBHOIfNeeded member function to registerBhoIfNeeded to be consistent with the other methods in the IChromeFrame interface. Fixes bug http://code.google.com/p/chromium/issues/detail?id=42790 Bug=42790 TBR=tommi Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46200

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -20 lines)			Patch
M	chrome_frame/CFInstall.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome_frame/chrome_frame_activex.h	View	2 chunks	+1 line, -6 lines	0 comments	Download
M	chrome_frame/chrome_frame_activex.cc	View	3 chunks	+3 lines, -11 lines	0 comments	Download
M	chrome_frame/chrome_frame_activex_base.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome_frame/chrome_tab.idl	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

lgtm.  thanks Ananta.