Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Side by Side Diff: chrome_frame/chrome_frame_activex_base.h

Issue 1831001: Fixes to address code review comments from tommi from CL http://codereview.ch... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome_frame/chrome_frame_activex.cc ('k') | chrome_frame/chrome_tab.idl » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_FRAME_CHROME_FRAME_ACTIVEX_BASE_H_ 5 #ifndef CHROME_FRAME_CHROME_FRAME_ACTIVEX_BASE_H_
6 #define CHROME_FRAME_CHROME_FRAME_ACTIVEX_BASE_H_ 6 #define CHROME_FRAME_CHROME_FRAME_ACTIVEX_BASE_H_
7 7
8 #include <atlbase.h> 8 #include <atlbase.h>
9 #include <atlcom.h> 9 #include <atlcom.h>
10 #include <atlctl.h> 10 #include <atlctl.h>
(...skipping 790 matching lines...) Expand 10 before | Expand all | Expand 10 after
801 801
802 if (!is_privileged_) { 802 if (!is_privileged_) {
803 DLOG(ERROR) << "Attempt to getEnabledExtensions in non-privileged mode"; 803 DLOG(ERROR) << "Attempt to getEnabledExtensions in non-privileged mode";
804 return E_ACCESSDENIED; 804 return E_ACCESSDENIED;
805 } 805 }
806 806
807 automation_client_->GetEnabledExtensions(NULL); 807 automation_client_->GetEnabledExtensions(NULL);
808 return S_OK; 808 return S_OK;
809 } 809 }
810 810
811 STDMETHOD(RegisterBHOIfNeeded)() { 811 STDMETHOD(registerBhoIfNeeded)() {
812 return E_NOTIMPL; 812 return E_NOTIMPL;
813 } 813 }
814 814
815 // Returns the vector of event handlers for a given event (e.g. "load"). 815 // Returns the vector of event handlers for a given event (e.g. "load").
816 // If the event type isn't recognized, the function fills in a descriptive 816 // If the event type isn't recognized, the function fills in a descriptive
817 // error (IErrorInfo) and returns E_INVALIDARG. 817 // error (IErrorInfo) and returns E_INVALIDARG.
818 HRESULT GetHandlersForEvent(BSTR event_type, EventHandlers** handlers) { 818 HRESULT GetHandlersForEvent(BSTR event_type, EventHandlers** handlers) {
819 DCHECK(handlers != NULL); 819 DCHECK(handlers != NULL);
820 820
821 // TODO(tommi): make these if() statements data-driven. 821 // TODO(tommi): make these if() statements data-driven.
(...skipping 307 matching lines...) Expand 10 before | Expand all | Expand 10 after
1129 EventHandlers onreadystatechanged_; 1129 EventHandlers onreadystatechanged_;
1130 EventHandlers onprivatemessage_; 1130 EventHandlers onprivatemessage_;
1131 EventHandlers onextensionready_; 1131 EventHandlers onextensionready_;
1132 1132
1133 // Handle network requests when host network stack is used. Passed to the 1133 // Handle network requests when host network stack is used. Passed to the
1134 // automation client on initialization. 1134 // automation client on initialization.
1135 UrlmonUrlRequestManager url_fetcher_; 1135 UrlmonUrlRequestManager url_fetcher_;
1136 }; 1136 };
1137 1137
1138 #endif // CHROME_FRAME_CHROME_FRAME_ACTIVEX_BASE_H_ 1138 #endif // CHROME_FRAME_CHROME_FRAME_ACTIVEX_BASE_H_
OLDNEW
« no previous file with comments | « chrome_frame/chrome_frame_activex.cc ('k') | chrome_frame/chrome_tab.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698