Issue 183025: Removes the deprecated version of PathService::Override that uses std::wstrin...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 183025: Removes the deprecated version of PathService::Override that uses std::wstrin... (Closed)

Created:
11 years, 3 months ago by tfarina (gmail-do not use)

Modified:
9 years, 7 months ago

Reviewers:
jcampan

CC:
chromium-reviews_googlegroups.com, brettw

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Removes the deprecated version of PathService::Override that uses std::wstring and fix the callers. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25185

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -13 lines)			Patch
M	base/path_service.h	View	3 chunks	+3 lines, -7 lines	0 comments	Download
M	base/path_service.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/app/chrome_dll_main.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tfarina (gmail-do not use)

On 2009/09/01 14:57:29, jcampan wrote: > LGTM Thanks Jay, can you land this to me?

11 years, 3 months ago (2009-09-02 15:31:14 UTC) #3

jcampan1

11 years, 3 months ago (2009-09-02 18:51:45 UTC) #4

It's in.

Jay

On Wed, Sep 2, 2009 at 8:31 AM, <thiago.farina@gmail.com> wrote:
> On 2009/09/01 14:57:29, jcampan wrote:
>>
>> LGTM
>
> Thanks Jay, can you land this to me?
>
>
> http://codereview.chromium.org/183025
>

Expand Messages | Collapse Messages