Avoids the use of "namespace using-directives" in a few places....

Avoids the use of "namespace using-directives" in a few places.

BUG=None
TEST=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25607

[brettw, 2009-08-31 17:02:07]

LGTM

[tfarina (gmail-do not use), 2009-09-02 15:40:37]

On 2009/08/31 17:02:07, brettw wrote:
> LGTM
Brett, can I find someone to land this to me?

[Nico, 2009-09-07 17:59:06]

http://codereview.chromium.org/183008/diff/1/3
File skia/ext/platform_device_mac.cc (left):

http://codereview.chromium.org/183008/diff/1/3#oldcode16
Line 16: using namespace gfx;
That won't work because this file uses some methods from the gfx namespace. I'll
just leave it in.

(Here's what the trybot complains about: http://pastebin.ca/1557476 )

[brettw, 2009-09-07 18:39:17]

On Mon, Sep 7, 2009 at 10:59 AM, <thakis@chromium.org> wrote:
>
> http://codereview.chromium.org/183008/diff/1/3
> File skia/ext/platform_device_mac.cc (left):
>
> http://codereview.chromium.org/183008/diff/1/3#oldcode16
> Line 16: using namespace gfx;
> That won't work because this file uses some methods from the gfx
> namespace. I'll just leave it in.
>
> (Here's what the trybot complains about: http://pastebin.ca/1557476 )
>
> http://codereview.chromium.org/183008

The more correct thing would be to add gfx:: to the front of those.

Brett

[Nico, 2009-09-07 18:41:28]

Since we're talking about this anyway: Is it a guideline to never use
namespace using directives, even in cc files? Why?

On Mon, Sep 7, 2009 at 11:38 AM, Brett Wilson<brettw@chromium.org> wrote:
> On Mon, Sep 7, 2009 at 10:59 AM, <thakis@chromium.org> wrote:
>>
>> http://codereview.chromium.org/183008/diff/1/3
>> File skia/ext/platform_device_mac.cc (left):
>>
>> http://codereview.chromium.org/183008/diff/1/3#oldcode16
>> Line 16: using namespace gfx;
>> That won't work because this file uses some methods from the gfx
>> namespace. I'll just leave it in.
>>
>> (Here's what the trybot complains about: http://pastebin.ca/1557476 )
>>
>> http://codereview.chromium.org/183008
>
> The more correct thing would be to add gfx:: to the front of those.
>
> Brett
>

[tfarina (gmail-do not use), 2009-09-07 21:19:27]

I updated the cl to use gfx:: in platform_device_mac.cc