Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 183003: Fix crash-on-launch on Snow Leopard (Closed)

Created:
11 years, 3 months ago by jeremy
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix crash-on-launch on Snow Leopard The signal-self syntax needed to fix bug 20370 doesn't work on Leopard and causes the Sandbox to barf so renderers don't star tup. We introduce a ;10.5_ONLY keyword to the sandbox that is substituted at runtime (the line with the rule is effectively uncommented). This allows us to use leopard or snow-leapard-only sandbox syntax BUG=20516 TEST=Chrome should no longer crash on launch under SL. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24777

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M chrome/renderer/renderer.sb View 1 chunk +2 lines, -1 line 1 comment Download
M chrome/renderer/renderer_main_platform_delegate_mac.mm View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jeremy
11 years, 3 months ago (2009-08-28 19:39:45 UTC) #1
John Grabowski
LGTM http://codereview.chromium.org/183003/diff/1/2 File chrome/renderer/renderer.sb (right): http://codereview.chromium.org/183003/diff/1/2#newcode10 Line 10: ; ;10.5_ONLY is substitued at runtime. :;10.5_ONLY" ...
11 years, 3 months ago (2009-08-28 19:41:33 UTC) #2
Mark Mentovai
Are processes allowed to send themselves signals under 10.6? Does yesterday's bug not occur there ...
11 years, 3 months ago (2009-08-28 21:50:11 UTC) #3
jeremy
11 years, 3 months ago (2009-08-28 21:57:19 UTC) #4
This was a quick fix for the dev release.
I've got a CL ready to be submitted that uses syntax that works on 10.5 &
10.6 and reverts this patch.

On Fri, Aug 28, 2009 at 2:50 PM, <mark@chromium.org> wrote:

> Are processes allowed to send themselves signals under 10.6?  Does
> yesterday's bug not occur there for other reasons?
>
>
> http://codereview.chromium.org/183003
>

Powered by Google App Engine
This is Rietveld 408576698