Index: chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc |
diff --git a/chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc b/chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc |
index 62f5b375c6c0981d1c324913c7d83a47d0545a80..47300bfa607e9b36b27f3208339e590089a2ee0e 100644 |
--- a/chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc |
+++ b/chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc |
@@ -50,6 +50,11 @@ class TwoClientLiveBookmarksSyncTest : public LiveSyncTest { |
} |
} |
+ // Overwrites ShouldDeleteProfile, so profile doesn't get deleted. |
+ virtual bool ShouldDeleteProfile() { |
+ return false; |
+ } |
+ |
// Overload this method in inherited class and return false to avoid |
// race condition (two clients trying to sync/commit at the same time). |
// Race condition may lead to duplicate bookmarks if there is existing |
@@ -89,8 +94,7 @@ class TwoClientLiveBookmarksSyncTest : public LiveSyncTest { |
FILE_PATH_LITERAL("live_sync_data")); |
FilePath source_file = sync_data_source.Append( |
bookmarks_file_name); |
- ASSERT_TRUE(file_util::PathExists(source_file)) |
- << "Could not locate test data file: " << source_file.value(); |
+ ASSERT_TRUE(file_util::PathExists(source_file)); |
// Now copy pre-generated bookmark file to default profile. |
ASSERT_TRUE(file_util::CopyFile(source_file, |
dest_user_data_dir_default.Append(FILE_PATH_LITERAL("bookmarks")))); |
@@ -147,10 +151,9 @@ class LiveSyncTestPrePopulatedHistory1K |
LiveSyncTestPrePopulatedHistory1K() {} |
virtual ~LiveSyncTestPrePopulatedHistory1K() {} |
- // This is used to pre-populate history data (1K URL Visit) to Client1 |
- // and Verifier Client. Invoked by InProcBrowserTest::SetUp before |
- // the browser is started. |
- virtual void SetUpUserDataDirectory() { |
+ // This is used to pre-populate history data (1K URL Visit)to Client1 |
+ // and Verifier Client. |
+ void PrePopulateHistory1K() { |
// Let's copy history files to default profile. |
FilePath dest_user_data_dir; |
PathService::Get(chrome::DIR_USER_DATA, &dest_user_data_dir); |
@@ -179,6 +182,11 @@ class LiveSyncTestPrePopulatedHistory1K |
} |
} |
+ virtual void SetUp() { |
+ PrePopulateHistory1K(); |
+ LiveSyncTest::SetUp(); |
+ } |
+ |
private: |
DISALLOW_COPY_AND_ASSIGN(LiveSyncTestPrePopulatedHistory1K); |
}; |
@@ -189,10 +197,10 @@ class LiveSyncTestBasicHierarchy50BM |
LiveSyncTestBasicHierarchy50BM() {} |
virtual ~LiveSyncTestBasicHierarchy50BM() {} |
- // Invoked by InProcBrowserTest::SetUp before the browser is started. |
- virtual void SetUpUserDataDirectory() { |
+ virtual void SetUp() { |
FilePath file_name(FILE_PATH_LITERAL("bookmarks_50BM5F3L")); |
PrePopulateBookmarksHierarchy(file_name); |
+ LiveSyncTest::SetUp(); |
} |
private: |
@@ -225,11 +233,10 @@ class LiveSyncTestComplexHierarchy800BM |
public: |
LiveSyncTestComplexHierarchy800BM() {} |
virtual ~LiveSyncTestComplexHierarchy800BM() {} |
- |
- // Invoked by InProcBrowserTest::SetUp before the browser is started. |
- virtual void SetUpUserDataDirectory() { |
+ virtual void SetUp() { |
FilePath file_name(FILE_PATH_LITERAL("bookmarks_800BM32F8L")); |
- PrePopulateBookmarksHierarchy(file_name); |
+ TwoClientLiveBookmarksSyncTest::PrePopulateBookmarksHierarchy(file_name); |
+ LiveSyncTest::SetUp(); |
} |
private: |
@@ -241,11 +248,10 @@ class LiveSyncTestHugeHierarchy5500BM |
public: |
LiveSyncTestHugeHierarchy5500BM() {} |
virtual ~LiveSyncTestHugeHierarchy5500BM() {} |
- |
- // Invoked by InProcBrowserTest::SetUp before the browser is started. |
- virtual void SetUpUserDataDirectory() { |
+ virtual void SetUp() { |
FilePath file_name(FILE_PATH_LITERAL("bookmarks_5500BM125F25L")); |
- PrePopulateBookmarksHierarchy(file_name); |
+ TwoClientLiveBookmarksSyncTest::PrePopulateBookmarksHierarchy(file_name); |
+ LiveSyncTest::SetUp(); |
} |
virtual bool ShouldSetupSyncWithRace() { |
return false; |
@@ -261,11 +267,11 @@ class LiveSyncTestDefaultIEFavorites |
LiveSyncTestDefaultIEFavorites() {} |
virtual ~LiveSyncTestDefaultIEFavorites() {} |
- // Invoked by InProcBrowserTest::SetUp before the browser is started. |
- virtual void SetUpUserDataDirectory() { |
+ virtual void SetUp() { |
const FilePath file_name( |
FILE_PATH_LITERAL("bookmarks_default_IE_favorites")); |
TwoClientLiveBookmarksSyncTest::PrePopulateBookmarksHierarchy(file_name); |
+ LiveSyncTest::SetUp(); |
} |
private: |