Issue 182021: [Mac] Fix operation of Control key in Omnibox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 182021: [Mac] Fix operation of Control key in Omnibox. (Closed)

Created:
11 years, 3 months ago by Scott Hess - ex-Googler

Modified:
9 years, 6 months ago

Reviewers:
rohitrao (ping after 24h)

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

[Mac] Fix operation of Control key in Omnibox. http://crbug.com/20455 TEST=Enter "this" into address bar. Hold Control, should see "www.this.com" as first item. Release, and it should go back to "this" immediately.

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -5 lines)			Patch
	M	chrome/browser/autocomplete/autocomplete_edit_view_mac.mm	View		2 chunks	+3 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rohitrao (ping after 24h)

LGTM Why did this fix things? What were we doing wrong before?

11 years, 3 months ago (2009-08-31 21:03:23 UTC) #2

Scott Hess - ex-Googler

11 years, 3 months ago (2009-08-31 21:21:02 UTC) #3

I believe it's the AutocompleteTextField stuff to rearrange the field
editor when things change, which can call OnWillBeginEditing().  This
change just addresses the symptom - I don't think the field editor
should need rearranging in this case in the first place, so I'm going
to look at whether that's not happening too often.  Also, I'm thinking
I might want to change that code to rearrange the editor directly (as
a subview of AutocompleteTextField), rather than being tricky.  Both
options are probably subtle, but I think rearranging directly won't
have as many edge cases.

If you didn't understand that, just smile and wave, you're very lucky :-).

-scott

On Mon, Aug 31, 2009 at 2:03 PM, <rohitrao@chromium.org> wrote:
> LGTM
>
> Why did this fix things? =A0What were we doing wrong before?
>
> http://codereview.chromium.org/182021
>

Expand Messages | Collapse Messages