Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 18194: Changes to the V8 debugger support which otherwise caused problems with Chrom... (Closed)

Created:
11 years, 11 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Changes to the V8 debugger support which otherwise caused problems with Chrome. Added quoting of the name of the ref property using {"ref":1} instead of {ref:1}. The Chrome C++ JSON parser implementation requires quoted property names. Changed the JSON format for non finite numbers. The previous formatting using NaN, Infinite and -Infinite caused the Chrome C++ JSON parser implementation to fail. Values "NaN", "Infinite" and "-Infinite" (incuding quotes) are now used. Reverted changes to DebugLookupResultValue (runtime.cc) from http://codereview.chromium.org/17377. The change caused callback into Chrome with the current V8 context expected to have a DOM Window global object. This is not the case when the debugger context is the active context. This causes properties from interceptors and accessors to be reported as undefined in the debugger. Committed: http://code.google.com/p/v8/source/detail?r=1101

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -40 lines) Patch
M src/mirror-delay.js View 2 chunks +20 lines, -1 line 0 comments Download
M src/runtime.cc View 3 chunks +36 lines, -19 lines 0 comments Download
M test/cctest/test-debug.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M test/mjsunit/mirror-object.js View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Thygesen Gjesse
11 years, 11 months ago (2009-01-19 15:12:12 UTC) #1
Christian Plesner Hansen
Lgtm, though using strings for numbers doesn't smell good.
11 years, 11 months ago (2009-01-19 15:17:54 UTC) #2
Søren Thygesen Gjesse
11 years, 11 months ago (2009-01-19 15:20:35 UTC) #3
On 2009/01/19 15:17:54, Christian Plesner Hansen wrote:
> Lgtm, though using strings for numbers doesn't smell good.

Thats right, but in the debugger protocol the value always have a type:

{"type"="number", "value"="NaN"} (or {"type"="number", "value"=42} for a finite
number).

Powered by Google App Engine
This is Rietveld 408576698