Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 17377: Refactored the mirror representation of properties. Removed the AssessorMirro... (Closed)

Created:
11 years, 11 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Refactored the mirror representation of properties. Removed the AssessorMirror and InterceptorPropertyMirror and moved all reflection for properties to PropertyMirror. From a PropertyMirror it can be checked whether a property has getter/setter defined in JavaScript and information on the getter/setter functions are now available. If calling the getter resulted in an exception this is reflected as well. Properties from interceptors are also reflected through PropertyMirror as the distinction did not make sense seen from a JavaScript debugging perspective. The isNative function on a PropertyMirror can be used to check whether a property is defined natively by the host (or V8). Simplified the local property lookup in the debug runtime call to just call GetProperty as the property is known to be a local property. Committed: http://code.google.com/p/v8/source/detail?r=1068

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -232 lines) Patch
M src/mirror-delay.js View 9 chunks +82 lines, -164 lines 0 comments Download
M src/runtime.cc View 6 chunks +59 lines, -29 lines 0 comments Download
M test/cctest/test-debug.cc View 1 chunk +45 lines, -27 lines 0 comments Download
M test/mjsunit/mirror-object.js View 2 chunks +30 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
11 years, 11 months ago (2009-01-13 14:03:18 UTC) #1
Mads Ager (chromium)
11 years, 11 months ago (2009-01-13 14:29:19 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698