Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1814002: Remove deprecated things from net test suite: (Closed)

Created:
10 years, 7 months ago by Paweł Hajdan Jr.
Modified:
9 years, 7 months ago
Reviewers:
eroman, wtc
CC:
chromium-reviews
Visibility:
Public.

Description

Remove deprecated things from net test suite: - URLRequestTestContext (from now on use TestURLRequestContext) - TestServerPageW (use TestServerPage). TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46044

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+291 lines, -298 lines) Patch
M chrome/browser/browser_focus_uitest.cc View 13 chunks +15 lines, -15 lines 0 comments Download
M chrome/browser/browser_keyevents_browsertest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/debugger/devtools_sanity_unittest.cc View 3 chunks +28 lines, -28 lines 0 comments Download
M chrome/browser/extensions/extension_browsertests_misc.cc View 9 chunks +31 lines, -31 lines 0 comments Download
M chrome/browser/find_bar_host_browsertest.cc View 25 chunks +39 lines, -39 lines 0 comments Download
M chrome/browser/gtk/bookmark_bar_gtk_interactive_uitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/history/redirect_uitest.cc View 7 chunks +23 lines, -24 lines 3 comments Download
M chrome/browser/login_prompt_uitest.cc View 7 chunks +17 lines, -17 lines 0 comments Download
M chrome/browser/notifications/notifications_interactive_uitest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/printing/printing_layout_uitest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc View 7 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/renderer_host/test/render_view_host_manager_browsertest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/repost_form_warning_uitest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/sessions/session_restore_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 33 chunks +57 lines, -57 lines 0 comments Download
M chrome/browser/tab_contents/view_source_uitest.cc View 6 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/tab_restore_uitest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/views/find_bar_host_interactive_uitest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/views/find_bar_host_uitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/interactive_ui/infobars_uitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome_frame/test/http_server.cc View 2 chunks +5 lines, -1 line 0 comments Download
M net/url_request/url_request_unittest.h View 2 chunks +0 lines, -9 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 20 chunks +20 lines, -20 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paweł Hajdan Jr.
10 years, 7 months ago (2010-04-29 17:59:30 UTC) #1
eroman
LGTM! http://codereview.chromium.org/1814002/diff/1/8 File chrome/browser/history/redirect_uitest.cc (right): http://codereview.chromium.org/1814002/diff/1/8#newcode55 chrome/browser/history/redirect_uitest.cc:55: std::string("client-redirect?") + final_url.spec()); nit: Can probably omit the ...
10 years, 7 months ago (2010-04-29 18:10:47 UTC) #2
wtc
10 years, 7 months ago (2010-04-29 23:13:40 UTC) #3 
LGTM.

Powered by Google App Engine
This is Rietveld 408576698