chrome/browser/browser_keyevents_browsertest.cc - Issue 1814002: Remove deprecated things from net test suite:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browser_keyevents_browsertest.cc

Issue 1814002: Remove deprecated things from net test suite: (Closed)

Patch Set: Created 10 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/browser_focus_uitest.cc ('k') | chrome/browser/debugger/devtools_sanity_unittest.cc » ('j') | chrome/browser/history/redirect_uitest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/browser_keyevents_browsertest.cc

diff --git a/chrome/browser/browser_keyevents_browsertest.cc b/chrome/browser/browser_keyevents_browsertest.cc

index 7f761037a6fc4d6a4ecea5c8792a0d0c1426d491..1f04eb81b00c9c7987340b12fc4fdddffb21facb 100644

--- a/chrome/browser/browser_keyevents_browsertest.cc

+++ b/chrome/browser/browser_keyevents_browsertest.cc

@@ -27,7 +27,7 @@

namespace {

-const wchar_t kTestingPage[] = L"files/keyevents_test.html";

+const char kTestingPage[] = "files/keyevents_test.html";

const wchar_t kSuppressEventJS[] =

L"window.domAutomationController.send(setDefaultAction('%ls', %ls));";

const wchar_t kGetResultJS[] =

@@ -349,7 +349,7 @@ IN_PROC_BROWSER_TEST_F(BrowserKeyEventsTest, NormalKeyEvents) {

HTTPTestServer* server = StartHTTPServer();

- GURL url = server->TestServerPageW(kTestingPage);

+ GURL url = server->TestServerPage(kTestingPage);

ui_test_utils::NavigateToURL(browser(), url);

ASSERT_NO_FATAL_FAILURE(ClickOnView(VIEW_ID_TAB_CONTAINER));

@@ -423,7 +423,7 @@ IN_PROC_BROWSER_TEST_F(BrowserKeyEventsTest, CtrlKeyEvents) {

HTTPTestServer* server = StartHTTPServer();

- GURL url = server->TestServerPageW(kTestingPage);

+ GURL url = server->TestServerPage(kTestingPage);

ui_test_utils::NavigateToURL(browser(), url);

ASSERT_NO_FATAL_FAILURE(ClickOnView(VIEW_ID_TAB_CONTAINER));

@@ -491,7 +491,7 @@ IN_PROC_BROWSER_TEST_F(BrowserKeyEventsTest, MAYBE_AccessKeys) {

HTTPTestServer* server = StartHTTPServer();

- GURL url = server->TestServerPageW(kTestingPage);

+ GURL url = server->TestServerPage(kTestingPage);

ui_test_utils::NavigateToURL(browser(), url);

ui_test_utils::RunAllPendingInMessageLoop();

@@ -546,7 +546,7 @@ IN_PROC_BROWSER_TEST_F(BrowserKeyEventsTest, MAYBE_AccessKeys) {

IN_PROC_BROWSER_TEST_F(BrowserKeyEventsTest, ReservedAccelerators) {

HTTPTestServer* server = StartHTTPServer();

- GURL url = server->TestServerPageW(kTestingPage);

+ GURL url = server->TestServerPage(kTestingPage);

ui_test_utils::NavigateToURL(browser(), url);

ASSERT_NO_FATAL_FAILURE(ClickOnView(VIEW_ID_TAB_CONTAINER));

« no previous file with comments | « chrome/browser/browser_focus_uitest.cc ('k') | chrome/browser/debugger/devtools_sanity_unittest.cc » ('j') | chrome/browser/history/redirect_uitest.cc » ('J')