Issue 1811001: Nicely steal moniker and bind context from the urlmon url request.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1811001: Nicely steal moniker and bind context from the urlmon url request. (Closed)

Created:
10 years, 8 months ago by stoyan

Modified:
9 years, 7 months ago

Reviewers:
amit, tommi (sloooow) - chröme

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Nicely steal moniker and bind context from the urlmon url request. BUG=42104

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -19 lines)			Patch
M	chrome_frame/urlmon_url_request.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome_frame/urlmon_url_request.cc	View	5 chunks	+35 lines, -18 lines	0 comments	Download
M	chrome_frame/urlmon_url_request_private.h	View	3 chunks	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

amit

10 years, 8 months ago (2010-04-28 20:09:35 UTC) #4

Drive by....
Since UrlmonUrlRequest already communicates with the manager using
PluginUrlRequestDelegate, won't it be better to add TerminateBind to that
interface instead of creating a callback object? In this case we just need to
set a boolean flag in the request object.

Expand Messages | Collapse Messages