Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3016)

Unified Diff: chrome_frame/urlmon_url_request_private.h

Issue 1811001: Nicely steal moniker and bind context from the urlmon url request. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome_frame/urlmon_url_request.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/urlmon_url_request_private.h
===================================================================
--- chrome_frame/urlmon_url_request_private.h (revision 45582)
+++ chrome_frame/urlmon_url_request_private.h (working copy)
@@ -36,7 +36,10 @@
HWND notification_window, IStream* cache);
// Used from "DownloadRequestInHost".
- void StealMoniker(IMoniker** moniker, IBindCtx** bctx);
+ // Callback will be invoked either right away (if operation is finished) or
+ // from inside ::OnStopBinding() when it is safe to reuse the bind_context.
+ typedef Callback2<IMoniker*, IBindCtx*>::Type TerminateBindCallback;
+ void TerminateBind(TerminateBindCallback* callback);
// Parent Window for UrlMon error dialogs
void set_parent_window(HWND parent_window) {
@@ -110,6 +113,10 @@
return pending_;
}
+ bool terminate_requested() const {
+ return terminate_bind_callback_.get() != NULL;
+ }
+
std::string response_headers() {
return response_headers_;
}
@@ -271,6 +278,7 @@
// Set to true if the ChromeFrame instance is running in privileged mode.
bool privileged_mode_;
bool pending_;
+ scoped_ptr<TerminateBindCallback> terminate_bind_callback_;
std::string response_headers_;
DISALLOW_COPY_AND_ASSIGN(UrlmonUrlRequest);
};
« no previous file with comments | « chrome_frame/urlmon_url_request.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698