Issue 181024: [Mac] Fix Option-return in Omnibox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 181024: [Mac] Fix Option-return in Omnibox. (Closed)

Created:
11 years, 3 months ago by Scott Hess - ex-Googler

Modified:
9 years, 6 months ago

Reviewers:
rohitrao (ping after 24h)

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

[Mac] Fix Option-return in Omnibox. Option-return inserted a literal newline, did not want. Also fixed Option-tab to not insert literal tab. http://crbug.com/17914 TEST=Type text, option-tab should not insert literal tab, option-return should not insert newline. Both should do nothing.

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -0 lines)			Patch
	M	chrome/browser/autocomplete/autocomplete_edit_view_mac.mm	View		2 chunks	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rohitrao (ping after 24h)

LGTM I like how the number of selectors we've overridden grows day by day.

11 years, 3 months ago (2009-08-31 20:59:22 UTC) #2

Scott Hess - ex-Googler

11 years, 3 months ago (2009-08-31 21:12:26 UTC) #3

There are a lot of selectors left ...

On Mon, Aug 31, 2009 at 1:59 PM, <rohitrao@chromium.org> wrote:
> LGTM
>
> I like how the number of selectors we've overridden grows day by day.
>
> http://codereview.chromium.org/181024
>

Expand Messages | Collapse Messages