Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 1806: Time singleton and resolution changes. (Closed)

Created:
12 years, 3 months ago by Dean McNamee
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Reapply r1633 (which was reverted by r1635), with some additional modifications. Consolidate all timer resolution code to time.h, and always depend on TimeTicks::Now for 1ms resolution. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=1893

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -90 lines) Patch
M base/event_recorder.cc View 1 2 4 chunks +0 lines, -10 lines 0 comments Download
M base/message_loop.cc View 1 2 2 chunks +0 lines, -18 lines 1 comment Download
M base/time.h View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M base/time_unittest_win.cc View 2 1 chunk +5 lines, -6 lines 0 comments Download
M base/time_win.cc View 1 2 3 chunks +86 lines, -53 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Dean McNamee
I had originally reverted this do to bugs.webkit.org being down and making all the unittests ...
12 years, 3 months ago (2008-09-07 16:33:43 UTC) #1
Evan Martin
http://codereview.chromium.org/1806/diff/1/4 File base/time.h (right): http://codereview.chromium.org/1806/diff/1/4#newcode439 Line 439: public: If only NowSingleton needs access to this, ...
12 years, 3 months ago (2008-09-07 16:41:27 UTC) #2
cpu_(ooo_6.6-7.5)
http://codereview.chromium.org/1806/diff/1/2 File base/time_win.cc (left): http://codereview.chromium.org/1806/diff/1/2#oldcode211 Line 211: return TimeTicks(0); // Broken, we don't guarantee this ...
12 years, 3 months ago (2008-09-07 20:15:55 UTC) #3
M-A Ruel
lgtm http://codereview.chromium.org/1806/diff/1/4 File base/time.h (right): http://codereview.chromium.org/1806/diff/1/4#newcode442 Line 442: static TickFunction tick_function_; If you want to ...
12 years, 3 months ago (2008-09-08 01:08:14 UTC) #4
darin (slow to review)
12 years, 3 months ago (2008-09-08 18:15:22 UTC) #5
LGTM

http://codereview.chromium.org/1806/diff/210/20
File base/message_loop.cc (right):

http://codereview.chromium.org/1806/diff/210/20#newcode10
Line 10: #include <mmsystem.h>
nit: please kill this include

Powered by Google App Engine
This is Rietveld 408576698