Time singleton and resolution changes.

base/message_loop.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/message_loop.h"
 
 #include <algorithm>
 
 #if defined(OS_WIN)
 #include <mmsystem.h>

[darin (slow to review), 2008/09/08 18:15:22]

nit: please kill this include

 #endif
 
 #include "base/compiler_specific.h"
 #include "base/logging.h"
 #include "base/message_pump_default.h"
 #include "base/string_util.h"
 #include "base/thread_local_storage.h"
 
 // a TLS index to the message loop for the current thread
 // Note that if we start doing complex stuff in other static initializers
@@ skipping 40 matching lines @@
 
 MessageLoop::MessageLoop(Type type)
     : type_(type),
       nestable_tasks_allowed_(true),
       exception_restoration_(false),
       state_(NULL),
       next_sequence_num_(0) {
   DCHECK(!tls_index_.Get()) << "should only have one message loop per thread";
   tls_index_.Set(this);
 
-  // TODO(darin): This does not seem like the best place for this code to live!
-#if defined(OS_WIN)
-  // We've experimented with all sorts of timers, and initially tried
-  // to avoid using timeBeginPeriod because it does affect the system
-  // globally.  However, after much investigation, it turns out that all
-  // of the major plugins (flash, windows media 9-11, and quicktime)
-  // already use timeBeginPeriod to increase the speed of the clock.
-  // Since the browser must work with these plugins, the browser already
-  // needs to support a fast clock.  We may as well use this ourselves,
-  // as it really is the best timer mechanism for our needs.
-  timeBeginPeriod(1);
-#endif
-
   // TODO(darin): Choose the pump based on the requested type.
 #if defined(OS_WIN)
   if (type_ == TYPE_DEFAULT) {
     pump_ = new base::MessagePumpDefault();
   } else {
     pump_ = new base::MessagePumpWin();
   }
 #else
   pump_ = new base::MessagePumpDefault();
 #endif
@@ skipping 18 matching lines @@
   DeletePendingTasks();
   ReloadWorkQueue();
   DeletePendingTasks();
 
   // Delete tasks in the delayed work queue.
   while (!delayed_work_queue_.empty()) {
     Task* task = delayed_work_queue_.top().task;
     delayed_work_queue_.pop();
     delete task;
   }
-
-#if defined(OS_WIN)
-  // Match timeBeginPeriod() from construction.
-  timeEndPeriod(1);
-#endif
 }
 
 void MessageLoop::AddDestructionObserver(DestructionObserver *obs) {
   DCHECK(this == current());
   destruction_observers_.AddObserver(obs);
 }
 
 void MessageLoop::RemoveDestructionObserver(DestructionObserver *obs) {
   DCHECK(this == current());
   destruction_observers_.RemoveObserver(obs);
@@ skipping 413 matching lines @@
 //------------------------------------------------------------------------------
 // MessageLoopForIO
 
 #if defined(OS_WIN)
 
 void MessageLoopForIO::WatchObject(HANDLE object, Watcher* watcher) {
   pump_win()->WatchObject(object, watcher);
 }
 
 #endif  // defined(OS_WIN)