Issue 180010: [Mac] Don't eat tab if tab-to-search hint not visible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 180010: [Mac] Don't eat tab if tab-to-search hint not visible. (Closed)

Created:
11 years, 3 months ago by Scott Hess - ex-Googler

Modified:
9 years, 6 months ago

Reviewers:
rohitrao (ping after 24h)

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

[Mac] Don't eat tab if tab-to-search hint not visible. http://crbug.com/20284 TEST=Type "test text". You should see "Type to search" hint. TAB should take you into the content view. Unfortunately, there are other unrelated bugs around the tab sequencing, so this only works with NTP on a new window. Hit TAB twice and you should start tabbing between thumbnails.

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -9 lines)			Patch
	M	chrome/browser/autocomplete/autocomplete_edit_view_mac.h	View		1 chunk	+4 lines, -3 lines	0 comments	Download
	M	chrome/browser/autocomplete/autocomplete_edit_view_mac.mm	View		3 chunks	+11 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

rohitrao (ping after 24h)

LGTM I don't understand part of the CL description. What only works on the NTP?

11 years, 3 months ago (2009-08-28 17:32:35 UTC) #2

Scott Hess - ex-Googler

NTP reference is because I couldn't reliably tab into the content area with other sites ...

11 years, 3 months ago (2009-08-28 17:35:21 UTC) #3

rohitrao (ping after 24h)

11 years, 3 months ago (2009-08-28 17:37:49 UTC) #4

Ok, got it.  I'll take a look at all the key view bugs sometime next week.

On Fri, Aug 28, 2009 at 10:34 AM, Scott Hess<shess@chromium.org> wrote:
> NTP reference is because I couldn't reliably tab into the content area
> with other sites because we have other bugs. =A0I could reliably do it
> using the NTP in a fresh window.
>
> -scott
>
>
> On Fri, Aug 28, 2009 at 10:32 AM, <rohitrao@chromium.org> wrote:
>> LGTM
>>
>> I don't understand part of the CL description. =A0What only works on the
>> NTP?
>>
>> http://codereview.chromium.org/180010
>>
>

Expand Messages | Collapse Messages