Issue 1797001: Add eglGetProcAddress to pgl.

Issue 1797001: Add eglGetProcAddress to pgl. (Closed)

Created:
10 years, 8 months ago by greggman

Modified:
9 years, 7 months ago

Reviewers:
alokp

CC:
chromium-reviews, apatrick_chromium

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add eglGetProcAddress to pgl. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45734

Patch Set 7 : '' #

Total comments: 2

Created: 10 years, 8 months ago

	Unified diffs	Side-by-side diffs	Stats (+156 lines, -461 lines)
M	gpu/gpu.gyp	View	1 chunk	+1 line, -0 lines	0 comments
D	gpu/pgl/egl_proc_address.c	View	1 chunk	+0 lines, -312 lines	0 comments
M	gpu/pgl/pgl.h	View	1 chunk	+3 lines, -0 lines	0 comments
A +	gpu/pgl/pgl_proc_address.cc	View	2 chunks	+152 lines, -149 lines	2 comments

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

alokp

http://codereview.chromium.org/1797001/diff/6001/7002 File gpu/pgl/pgl.h (right): http://codereview.chromium.org/1797001/diff/6001/7002#newcode53 gpu/pgl/pgl.h:53: void (* pglGetProcAddress(char const * procname))(); I think you ...

10 years, 8 months ago (2010-04-26 21:54:05 UTC) #2

greggman

10 years, 8 months ago (2010-04-26 23:38:30 UTC) #3

alokp

lgtm http://codereview.chromium.org/1797001/diff/13003/27004 File gpu/pgl/pgl_proc_address.cc (right): http://codereview.chromium.org/1797001/diff/13003/27004#newcode1 gpu/pgl/pgl_proc_address.cc:1: // Copyright (c) 2009 The Chromium Authors. All ...

10 years, 8 months ago (2010-04-27 11:20:32 UTC) #4

alokp

10 years, 8 months ago (2010-04-27 17:46:44 UTC) #5

I just noticed that according to EGL spec this function is only to be used for
egl and gl extension functions - note the core ones. So I am not anymore sure if
we are doing the right thing.

Expand Messages | Collapse Messages