Issue 1796010: Fix some memory leaks in GPU tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1796010: Fix some memory leaks in GPU tests. (Closed)

Created:
10 years, 7 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
apatrick_chromium

CC:
chromium-reviews, apatrick_chromium

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Fix some memory leaks in GPU tests. BUG=42904 TEST=run the tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46303

Patch Set 1 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -30 lines)			Patch
M	gpu/command_buffer/client/cmd_buffer_helper_test.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	gpu/command_buffer/client/fenced_allocator.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	gpu/command_buffer/client/fenced_allocator_test.cc	View	3 chunks	+0 lines, -7 lines	0 comments	Download
M	gpu/command_buffer/client/ring_buffer_test.cc	View	11 chunks	+10 lines, -19 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

Please be careful in this review as I'm not perfectly clear on the various ownership ...

10 years, 7 months ago (2010-04-30 21:42:57 UTC) #1

apatrick_chromium

10 years, 7 months ago (2010-04-30 21:50:20 UTC) #2

This code has been around for a long time in one form or another and has been
touched by a lot of people as it moved from place to place. I am not sure what
the intent of the release calls was. It is possible that they were intended to
be resets to force any destructor crash to happen within TearDown. If the tests
pass I'm comfortable with the change. They run on the trybots.

LGTM

Expand Messages | Collapse Messages