Get rid of BookmarkEditor::Show()'s BookmarkEditor::Handler argument.

Get rid of BookmarkEditor::Show()'s BookmarkEditor::Handler argument.

Still to do: get rid of things which hang on to a handler just so they can pass
it to Show().

BUG=38908
TEST=everything still works

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45813

[viettrungluu, 2010-04-28 08:23:05]

I'll separately chase down the various BookmarkEditor::Handler arguments in the
Mac code to see which ones (if any) are really necessary.

[sky, 2010-04-28 16:09:45]

http://codereview.chromium.org/1795007/diff/7001/8007
File chrome/browser/gtk/bookmark_editor_gtk.cc (right):

http://codereview.chromium.org/1795007/diff/7001/8007#newcode332
chrome/browser/gtk/bookmark_editor_gtk.cc:332: bb_model_, new_parent, details_,
new_title, new_url, NULL);
Can you cleanup up bookmark_utils too?

[viettrungluu, 2010-04-28 16:20:08]

http://codereview.chromium.org/1795007/diff/7001/8007
File chrome/browser/gtk/bookmark_editor_gtk.cc (right):

http://codereview.chromium.org/1795007/diff/7001/8007#newcode332
chrome/browser/gtk/bookmark_editor_gtk.cc:332: bb_model_, new_parent, details_,
new_title, new_url, NULL);
On 2010/04/28 16:09:45, sky wrote:
> Can you cleanup up bookmark_utils too?

One step at a time. ;-) I have to make sure that no handler gets passed in in
the Mac code (a little more annoying due to messy code). Probably I'll be able
to get rid of BookmarkEditor::Handler altogether.

[sky, 2010-04-28 16:43:47]

Fair enough. LGTM