Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Unified Diff: chrome/browser/cocoa/bookmark_editor_base_controller.mm

Issue 1795007: Get rid of BookmarkEditor::Show()'s BookmarkEditor::Handler argument. (Closed)
Patch Set: baz Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/cocoa/bookmark_editor_base_controller.mm
diff --git a/chrome/browser/cocoa/bookmark_editor_base_controller.mm b/chrome/browser/cocoa/bookmark_editor_base_controller.mm
index 017d477c3373b2d57930e5476367d3ddb2ea415a..ac66f2019c49b87277d88f90f051364589a3117b 100644
--- a/chrome/browser/cocoa/bookmark_editor_base_controller.mm
+++ b/chrome/browser/cocoa/bookmark_editor_base_controller.mm
@@ -59,16 +59,16 @@ void BookmarkEditor::Show(gfx::NativeWindow parent_hwnd,
Profile* profile,
const BookmarkNode* parent,
const EditDetails& details,
- Configuration configuration,
- Handler* handler) {
+ Configuration configuration) {
BookmarkEditorBaseController* controller = nil;
+ // TODO(viettrungluu): get rid of |handler:| below and elsewhere.
if (details.type == EditDetails::NEW_FOLDER) {
controller = [[BookmarkAllTabsController alloc]
initWithParentWindow:parent_hwnd
profile:profile
parent:parent
configuration:configuration
- handler:handler];
+ handler:NULL];
} else {
controller = [[BookmarkEditorController alloc]
initWithParentWindow:parent_hwnd
@@ -76,7 +76,7 @@ void BookmarkEditor::Show(gfx::NativeWindow parent_hwnd,
parent:parent
node:details.existing_node
configuration:configuration
- handler:handler];
+ handler:NULL];
}
[controller runAsModalSheet];
}

Powered by Google App Engine
This is Rietveld 408576698