Issue 178023: Disk cache: Add a histogram to measure the latency of...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 178023: Disk cache: Add a histogram to measure the latency of... (Closed)

Created:
11 years, 3 months ago by rvargas (doing something else)

Modified:
9 years, 6 months ago

Reviewers:
Nicolas Sylvain, darin (slow to review)

CC:
chromium-reviews_googlegroups.com, willchan no longer on Chromium

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Disk cache: Add a histogram to measure the latency of asynchronous IO. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24829

Patch Set 1 #

Total comments: 1

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -13 lines)			Patch
	M	net/disk_cache/entry_impl.h	View		3 chunks	+11 lines, -10 lines	1 comment	Download
	M	net/disk_cache/entry_impl.cc	View		3 chunks	+9 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

11 years, 3 months ago (2009-08-28 23:14:37 UTC) #3

http://codereview.chromium.org/178023/diff/1/3
File net/disk_cache/entry_impl.h (right):

http://codereview.chromium.org/178023/diff/1/3#newcode24
Line 24: enum Operation {
nit: though kFoo is encouraged by the style guide, we have been trying to stick
with the old MACRO_STYLE rule for enum names.  (This is in the chrome style
guide.)

Expand Messages | Collapse Messages