Disk cache: Add a histogram to measure the latency of...

net/disk_cache/entry_impl.h

Index: net/disk_cache/entry_impl.h
===================================================================
--- net/disk_cache/entry_impl.h	(revision 24800)
+++ net/disk_cache/entry_impl.h	(working copy)
@@ -21,6 +21,14 @@
   friend class base::RefCounted<EntryImpl>;
   friend class SparseControl;
  public:
+  enum Operation {

[darin (slow to review), 2009/08/28 23:14:37]

nit: though kFoo is encouraged by the style guide, we have been trying to stick
with the old MACRO_STYLE rule for enum names.  (This is in the chrome style
guide.)

+    kRead,
+    kWrite,
+    kSparseRead,
+    kSparseWrite,
+    kAsyncIO
+  };
+
   EntryImpl(BackendImpl* backend, Addr address);
 
   // Entry interface.
@@ -99,18 +107,14 @@
   // the upgrade tool.
   void SetTimes(base::Time last_used, base::Time last_modified);
 
+  // Generates a histogram for the time spent working on this operation.
+  void ReportIOTime(Operation op, const base::Time& start);
+
  private:
   enum {
      kNumStreams = 3
   };
 
-  enum Operation {
-    kRead,
-    kWrite,
-    kSparseRead,
-    kSparseWrite
-  };
-
   ~EntryImpl();
 
   // Initializes the storage for an internal or external data block.
@@ -166,9 +170,6 @@
   // actual cleanup.
   void GetData(int index, char** buffer, Addr* address);
 
-  // Generates a histogram for the time spent working on this operation.
-  void ReportIOTime(Operation op, const base::Time& start);
-
   // Logs this entry to the internal trace buffer.
   void Log(const char* msg);