Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3846)

Unified Diff: chrome/app/chrome_exe_main.cc

Issue 178011: Parameterize the Google Update appid at build time instead of hard coding it ... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/app/chrome_exe_main.cc
===================================================================
--- chrome/app/chrome_exe_main.cc (revision 24686)
+++ chrome/app/chrome_exe_main.cc (working copy)
@@ -19,6 +19,9 @@
#include "sandbox/src/sandbox_factory.h"
#include "sandbox/src/dep.h"
+// Generataed header containing the Google Update appid.
+#include "appid.h"
+
int APIENTRY wWinMain(HINSTANCE instance, HINSTANCE prev_instance,
wchar_t* command_line, int) {
base::EnableTerminationOnHeapCorruption();
@@ -50,9 +53,8 @@
#if defined(GOOGLE_CHROME_BUILD)
google_update::GoogleUpdateClient client;
- // TODO(erikkay): Get guid from build macros rather than hardcoding.
// TODO(erikkay): verify client.Init() return value for official builds
- client.Init(L"{8A69D345-D564-463c-AFF1-A69D9E530F96}", dll_name);
+ client.Init(google_update::kChromeGuid, dll_name);
dll_full_path = client.GetDLLFullPath();
versionned_path = client.GetDLLPath();
#else

Powered by Google App Engine
This is Rietveld 408576698