Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2697)

Unified Diff: app/app.gyp

Issue 178011: Parameterize the Google Update appid at build time instead of hard coding it ... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/common.gypi » ('j') | chrome/tools/build/appid.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: app/app.gyp
===================================================================
--- app/app.gyp (revision 24686)
+++ app/app.gyp (working copy)
@@ -297,6 +297,51 @@
'dependencies': ['../build/win/system.gyp:cygwin'],
}],
],
- },
+ },
+ {
+ 'target_name': 'app_id',
+ 'type': 'none',
+ 'msvs_guid': '83100055-172B-49EA-B422-B1A92B627D37',
+ 'conditions': [
+ ['OS=="win"',
+ {
+ 'actions': [
+ {
+ 'action_name': 'appid',
+ 'variables': {
+ 'appid_py': '../chrome/tools/build/appid.py',
+ },
+ 'conditions': [
+ [ 'branding=="Chrome"', {
+ 'variables': {
+ 'appid_value': '<(google_update_appid)',
+ },
+ }, { # else
+ 'variables': {
+ 'appid_value': '',
+ },
+ }],
+ ],
+ 'inputs': [
+ '<(appid_py)',
+ ],
+ 'outputs': [
+ '<(SHARED_INTERMEDIATE_DIR)/chrome/appid.h',
+ 'tools/build/_always_run_appid_py.marker',
sgk 2009/09/03 00:25:23 There's a problem here. You're using a .marker fi
+ ],
+ 'action': [
+ 'python',
+ '<(appid_py)',
+ '-a', '<(appid_value)',
+ '-o', '<(SHARED_INTERMEDIATE_DIR)/chrome/appid.h',
+ ],
+ 'process_outputs_as_sources': 1,
+ 'message': 'Generating appid information in <(SHARED_INTERMEDIATE_DIR)/chrome/appid.h'
+ },
+ ],
+ },
+ ],
+ ],
+ },
],
}
« no previous file with comments | « no previous file | build/common.gypi » ('j') | chrome/tools/build/appid.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698