GTK: The cookie prompt should allow the user to set expire date for HTML cookies

chrome/browser/gtk/gtk_chrome_cookie_view.h

Index: chrome/browser/gtk/gtk_chrome_cookie_view.h
diff --git a/chrome/browser/gtk/gtk_chrome_cookie_view.h b/chrome/browser/gtk/gtk_chrome_cookie_view.h
index e729b0433dee06a3420da7811278c0b96ae02bad..aa663a9cd511a68ef97b853e733434a77723103e 100644
--- a/chrome/browser/gtk/gtk_chrome_cookie_view.h
+++ b/chrome/browser/gtk/gtk_chrome_cookie_view.h
@@ -63,7 +63,14 @@ typedef struct {
   GtkWidget* cookie_path_entry_;
   GtkWidget* cookie_send_for_entry_;
   GtkWidget* cookie_created_entry_;
+
+  // Note: These two widgets are mutually exclusive based on what
+  // |editable_expiration| was when the cookie view was created. One of these
+  // variables will be NULL.
   GtkWidget* cookie_expires_entry_;

[Evan Stade, 2010/04/27 19:32:35]

it seems that the code would be a little more self-documenting if you saved
editable_expiration into a member var, and combined these two widgets (because
then the check would be

if (editable_expiration_)

instead of

if (cookie_expires_entry_)

but it's up to you.

+  GtkWidget* cookie_expires_combobox_;
+
+  GtkListStore* cookie_expires_combobox_store_;
 
   // The database details widgets.
   GtkWidget* database_details_table_;
@@ -110,7 +117,7 @@ typedef struct {
 GType gtk_chrome_cookie_view_get_type();
 
 // Builds a new cookie view.
-GtkChromeCookieView* gtk_chrome_cookie_view_new();
+GtkWidget* gtk_chrome_cookie_view_new(gboolean editable_expiration);
 
 // Clears the cookie view.
 void gtk_chrome_cookie_view_clear(GtkChromeCookieView* widget);
@@ -167,4 +174,8 @@ void gtk_chrome_cookie_view_display_appcache_created(
     GtkChromeCookieView* self,
     const GURL& manifest_url);
 
+// If |editable_expiration| was true at construction time, returns the value of
+// the combo box. Otherwise, returns false.
+bool gtk_chrome_cookie_view_session_expires(GtkChromeCookieView* self);
+
 #endif  // CHROME_BROWSER_GTK_GTK_CHROME_COOKIE_VIEW_H_