Issue 177022: Turn on the linux debug bots now that we archive the results for them.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 177022: Turn on the linux debug bots now that we archive the results for them. (Closed)

Created:
11 years, 3 months ago by ojan

Modified:
9 years, 7 months ago

Reviewers:
arv (Not doing code reviews)

CC:
chromium-reviews_googlegroups.com, Pam (message me for reviews), darin (slow to review)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Turn on the linux debug bots now that we archive the results for them. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24760

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -4 lines)			Patch
	M	webkit/tools/layout_tests/flakiness_dashboard.html	View		1 chunk	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

arv (Not doing code reviews)

11 years, 3 months ago (2009-08-28 18:34:36 UTC) #2

LGTM

On Fri, Aug 28, 2009 at 11:02,  <ojan@chromium.org> wrote:
> Reviewers: arv,
>
> Description:
> Turn on the linux debug bots now that we archive the results for them.
>
> Please review this at http://codereview.chromium.org/177022
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
> =C2=A0M =C2=A0 =C2=A0 webkit/tools/layout_tests/flakiness_dashboard.html
>
>
> Index: webkit/tools/layout_tests/flakiness_dashboard.html
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- webkit/tools/layout_tests/flakiness_dashboard.html =C2=A0(revision 24=
746)
> +++ webkit/tools/layout_tests/flakiness_dashboard.html =C2=A0(working cop=
y)
> @@ -149,10 +149,9 @@
> =C2=A0 =C2=A0 'Webkit (dbg)(2)': 'webkit-dbg-2',
> =C2=A0 =C2=A0 'Webkit (dbg)(3)': 'webkit-dbg-3',
> =C2=A0 =C2=A0 'Webkit Linux': 'webkit-rel-linux',
> - =C2=A0 =C2=A0// TODO(ojan): Comment out linux debug builders until they=
 archive
> results.
> - =C2=A0 =C2=A0// 'Webkit Linux (dbg)(1)': 'webkit-dbg-linux-1',
> - =C2=A0 =C2=A0// 'Webkit Linux (dbg)(2)': 'webkit-dbg-linux-2',
> - =C2=A0 =C2=A0// 'Webkit Linux (dbg)(3)': 'webkit-dbg-linux-3',
> + =C2=A0 =C2=A0'Webkit Linux (dbg)(1)': 'webkit-dbg-linux-1',
> + =C2=A0 =C2=A0'Webkit Linux (dbg)(2)': 'webkit-dbg-linux-2',
> + =C2=A0 =C2=A0'Webkit Linux (dbg)(3)': 'webkit-dbg-linux-3',
> =C2=A0 =C2=A0 'Webkit Mac10.5': 'webkit-rel-mac5',
> =C2=A0 =C2=A0 'Webkit Mac10.5 (dbg)(1)': 'webkit-dbg-mac5-1',
> =C2=A0 =C2=A0 'Webkit Mac10.5 (dbg)(2)': 'webkit-dbg-mac5-2',
>
>
>



--=20
erik

Expand Messages | Collapse Messages