Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: command_buffer/service/win/d3d9/render_surface_d3d9.h

Issue 176026: C++ Readability (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/o3d/
Patch Set: '' Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | command_buffer/service/win/d3d9/render_surface_d3d9.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: command_buffer/service/win/d3d9/render_surface_d3d9.h
===================================================================
--- command_buffer/service/win/d3d9/render_surface_d3d9.h (revision 26267)
+++ command_buffer/service/win/d3d9/render_surface_d3d9.h (working copy)
@@ -37,61 +37,120 @@
// render surface-related resource classes.
#include <d3d9.h>
+#include "base/scoped_ptr.h"
#include "command_buffer/common/cross/gapi_interface.h"
+#include "command_buffer/service/cross/resource.h"
#include "command_buffer/service/win/d3d9/d3d9_utils.h"
-#include "command_buffer/service/cross/resource.h"
+#include "command_buffer/service/win/d3d9/texture_d3d9.h"
namespace o3d {
namespace command_buffer {
class GAPID3D9;
+// The RenderSurfaceD3D class represents a render surface resource in the d3d
+// backend of the command buffer server.
class RenderSurfaceD3D9 : public RenderSurface {
public:
+
+ // Creates a render surface resource based on D3D.
+ // Parameters:
+ // width - width of the surface to be created. Must match width of texture
+ // at mip_level.
+ // height - height of the surface to be created. Must match width of
+ // texture at mip_level.
+ // mip_level - mip level of the texture to which the render surface maps.
+ // side - side of a cube if texture is a cube texture. Does not apply to
+ // texture 2d's.
+ // texture - the texture to which this render surface maps. Not owned by
+ // the RenderSurfaceD3D9.
+ // direct3d_surface - a surface to be used as this render surface's
+ // rendering surface. The new RenderSurfaceD3D9 will own the
+ // direct3d_surface.
RenderSurfaceD3D9(int width,
int height,
int mip_level,
int side,
- TextureD3D9 *texture,
- IDirect3DSurface9* direct3d_surface);
+ TextureD3D9 *texture,
+ IDirect3DSurface9 *direct3d_surface);
+
+ // Destructor for the render surface.
virtual ~RenderSurfaceD3D9() {}
+ // Performs the setup necessary to create a render surface resource based on
+ // D3D and returns a new one if possibe.
+ // Parameters:
+ // gapi - the gapi interface to D3D.
+ // width - width of the surface to be created. Must match width of texture
+ // at mip_level.
+ // height - height of the surface to be created. Must match width of
+ // texture at mip_level.
+ // mip_level - mip level of the texture to which the render surface maps.
+ // side - side of a cube if texture is a cube texture. Does not apply to
+ // texture 2d's.
+ // texture - the texture to which this render surface maps.
+ // Returns:
+ // a new RenderSurfaceD3D9 or NULL on failure
static RenderSurfaceD3D9* Create(GAPID3D9 *gapi,
int width,
int height,
int mip_level,
int side,
TextureD3D9 *texture);
- IDirect3DSurface9* GetSurfaceHandle() const {
+
+ // Returns a reference to the actual direct3d surface that is rendered to.
+ IDirect3DSurface9* direct3d_surface() const {
return direct3d_surface_;
}
private:
CComPtr<IDirect3DSurface9> direct3d_surface_;
- unsigned int width_;
- unsigned int height_;
- unsigned int mip_level_;
- TextureD3D9* texture_;
+ int width_;
+ int height_;
+ int mip_level_;
+ TextureD3D9 *texture_;
DISALLOW_COPY_AND_ASSIGN(RenderSurfaceD3D9);
};
+// The RenderDepthStencilSurfaceD3D class represents a depth stencil surface
+// resource in the d3d backend of the command buffer server.
class RenderDepthStencilSurfaceD3D9 : public RenderDepthStencilSurface {
public:
+
+ // Creates a depth stencil surface resource based on D3D.
+ // Parameters:
+ // width - width of the surface to be created.
+ // height - height of the surface to be created.
+ // direct3d_surface - a surface to be used as this depth stencil surface's
+ // rendering rendering surface. The new RenderDepthStencilSurfaceD3D9
+ // will own the direct3d_surface.
RenderDepthStencilSurfaceD3D9(int width,
int height,
- IDirect3DSurface9* direct3d_surface);
+ IDirect3DSurface9 *direct3d_surface);
+
+ // Destructor for the depth stencil surface.
virtual ~RenderDepthStencilSurfaceD3D9() {}
- static RenderDepthStencilSurfaceD3D9* Create(
- GAPID3D9 *gapi,
- int width,
- int height);
- IDirect3DSurface9* GetSurfaceHandle() const {
+
+ // Performs the setup necessary to create a depth stencil surface resource
+ // based on D3D and returns a new one if possibe.
+ // Parameters:
+ // gapi - the gapi interface to D3D.
+ // width - width of the surface to be created.
+ // height - height of the surface to be created.
+ // Returns:
+ // a new RenderDepthStencilSurfaceD3D9 or NULL on failure.
+ static RenderDepthStencilSurfaceD3D9* Create(GAPID3D9 *gapi,
+ int width,
+ int height);
+
+ // Returns a reference to the actual direct3d surface that is rendered to.
+ IDirect3DSurface9* direct3d_surface() const {
return direct3d_surface_;
}
private:
CComPtr<IDirect3DSurface9> direct3d_surface_;
- unsigned int width_;
- unsigned int height_;
+ int width_;
+ int height_;
DISALLOW_COPY_AND_ASSIGN(RenderDepthStencilSurfaceD3D9);
};
« no previous file with comments | « no previous file | command_buffer/service/win/d3d9/render_surface_d3d9.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698