Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issue 1758003: Changed inlined property load detection on ARM... (Closed)

Created:
10 years, 8 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Changed inlined property load detection on ARM Instaed of having a nop after all non-inlined calls to load IC use a different nop (mov r1, r1 instead of mov r0, r0) to detect an inlined load IC. Added more infrastructure to the deferred code handling to make it possbile to block constant pool emitting in a deferred code block, including the branch instruction ending the deferred code block. Addressed a couple of comments to http://codereview.chromium.org/1715003, including adding an assert to make sure that the patching of an ldr instruction is always possible. Committed: http://code.google.com/p/v8/source/detail?r=4480

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 4

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -50 lines) Patch
M src/arm/assembler-arm.h View 3 chunks +14 lines, -5 lines 0 comments Download
M src/arm/assembler-arm.cc View 1 4 chunks +22 lines, -3 lines 0 comments Download
M src/arm/codegen-arm.h View 1 2 2 chunks +9 lines, -1 line 0 comments Download
M src/arm/codegen-arm.cc View 1 2 1 chunk +15 lines, -3 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 3 chunks +3 lines, -18 lines 0 comments Download
M src/arm/ic-arm.cc View 1 2 1 chunk +16 lines, -8 lines 0 comments Download
M src/arm/virtual-frame-arm.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/arm/virtual-frame-arm.cc View 1 chunk +1 line, -9 lines 0 comments Download
M src/codegen.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/codegen.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Thygesen Gjesse
10 years, 8 months ago (2010-04-22 21:43:28 UTC) #1
Mads Ager (chromium)
LGTM http://codereview.chromium.org/1758003/diff/11001/12003 File src/arm/assembler-arm.h (right): http://codereview.chromium.org/1758003/diff/11001/12003#newcode899 src/arm/assembler-arm.h:899: void nop(int type = 0); Create an enum ...
10 years, 8 months ago (2010-04-23 06:55:40 UTC) #2
Søren Thygesen Gjesse
10 years, 8 months ago (2010-04-23 07:42:16 UTC) #3
http://codereview.chromium.org/1758003/diff/11001/12003
File src/arm/assembler-arm.h (right):

http://codereview.chromium.org/1758003/diff/11001/12003#newcode899
src/arm/assembler-arm.h:899: void nop(int type = 0);
On 2010/04/23 06:55:40, Mads Ager wrote:
> Create an enum for the types so they can be named?

Kept int here, but added an enum to the code generator for use when calling
nop(x).

http://codereview.chromium.org/1758003/diff/11001/12004
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/1758003/diff/11001/12004#newcode5253
src/arm/codegen-arm.cc:5253: // inobject has been inlined..
On 2010/04/23 06:55:40, Mads Ager wrote:
> Extra period at end of line.

Done.

Powered by Google App Engine
This is Rietveld 408576698