Fix some uses of scoped_ptr.release() in net/ such that the return value is not ignored.

Fix some uses of scoped_ptr.release() in net/ such that the return value is not ignored.

client_socket_pool_base.cc change contributed by vandebo@chromium

BUG=42904
TEST=existing net tests/

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46409

[vandebo (ex-Chrome), 2010-04-30 21:51:40]

http://codereview.chromium.org/1756019/diff/1/2
File net/disk_cache/entry_impl.cc (right):

http://codereview.chromium.org/1756019/diff/1/2#newcode865
net/disk_cache/entry_impl.cc:865:
EXPLICITLY_UNUSED(user_buffers_[index].release());
Maybe UNUSED_RESULT would be a better name?  This name makes the argument seem
unnecessary.

http://codereview.chromium.org/1756019/diff/1/5
File net/socket/client_socket_pool_base.h (right):

http://codereview.chromium.org/1756019/diff/1/5#newcode532
net/socket/client_socket_pool_base.h:532: delete request;
You've got this backward.  When released, the request isn't freed.

[willchan no longer on Chromium, 2010-04-30 21:54:33]

LGTM

http://codereview.chromium.org/1756019/diff/1/2
File net/disk_cache/entry_impl.cc (right):

http://codereview.chromium.org/1756019/diff/1/2#newcode865
net/disk_cache/entry_impl.cc:865:
EXPLICITLY_UNUSED(user_buffers_[index].release());
Where's this macro from?  How does it differ from ALLOW_UNUSED?

[willchan no longer on Chromium, 2010-04-30 21:59:38]

Oops, I misread that.  Ignore my comment on ALLOW_UNUSED.

[Evan Stade, 2010-05-03 23:53:05]

http://codereview.chromium.org/1756019/diff/1/5
File net/socket/client_socket_pool_base.h (right):

http://codereview.chromium.org/1756019/diff/1/5#newcode532
net/socket/client_socket_pool_base.h:532: delete request;
On 2010/04/30 21:51:41, vandebo wrote:
> You've got this backward.  When released, the request isn't freed.

fiddled with this. Now ClientSocketPoolBaseHelper::RequestSocket always takes
ownership.

[vandebo (ex-Chrome), 2010-05-04 18:43:20]

LGTM