Fix some uses of scoped_ptr.release() in net/ such that the return value is not ignored.

net/disk_cache/entry_impl.cc

 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/disk_cache/entry_impl.h"
 
 #include "base/histogram.h"
 #include "base/message_loop.h"
 #include "base/string_util.h"
 #include "net/base/io_buffer.h"
@@ skipping 843 matching lines @@
   // TODO(rvargas): figure out if it's worth to re-enable posting operations.
   // Right now it is only used from GrowUserBuffer, not the destructor, and
   // it is not accounted for from the point of view of the total number of
   // pending operations of the cache. It is also racing with the actual write
   // on the GrowUserBuffer path because there is no code to exclude the range
   // that is going to be written.
   async = false;
   if (async) {
     if (!file->PostWrite(user_buffers_[index].get(), len, offset))
       return false;
+    // The buffer is deleted from the PostWrite operation.
+    ignore_result(user_buffers_[index].release());
   } else {
     if (!file->Write(user_buffers_[index].get(), len, offset, NULL, NULL))
       return false;
     user_buffers_[index].reset(NULL);
   }
 
-  // The buffer is deleted from the PostWrite operation.
-  user_buffers_[index].release();
-
   return true;
 }
 
 int EntryImpl::InitSparseData() {
   if (sparse_.get())
     return net::OK;
 
   sparse_.reset(new SparseControl(this));
   int result = sparse_->Init();
   if (net::OK != result)
     sparse_.reset();
   return result;
 }
 
 void EntryImpl::SetEntryFlags(uint32 flags) {
   entry_.Data()->flags |= flags;
   entry_.set_modified();
 }
 
 uint32 EntryImpl::GetEntryFlags() {
   return entry_.Data()->flags;
 }
 
 void EntryImpl::GetData(int index, char** buffer, Addr* address) {
   if (user_buffers_[index].get()) {
-    // The data is already in memory, just copy it an we're done.
+    // The data is already in memory, just copy it and we're done.
     int data_len = entry_.Data()->data_size[index];
     DCHECK(data_len <= kMaxBlockSize);
     *buffer = new char[data_len];
     memcpy(*buffer, user_buffers_[index].get(), data_len);
     return;
   }
 
   // Bad news: we'd have to read the info from disk so instead we'll just tell
   // the caller where to read from.
   *buffer = NULL;
@@ skipping 16 matching lines @@
   Trace("%s 0x%p 0x%x 0x%x", msg, reinterpret_cast<void*>(this),
         entry_.address().value(), node_.address().value());
 
   Trace("  data: 0x%x 0x%x 0x%x", entry_.Data()->data_addr[0],
         entry_.Data()->data_addr[1], entry_.Data()->long_key);
 
   Trace("  doomed: %d 0x%x", doomed_, dirty);
 }
 
 }  // namespace disk_cache