Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 1756015: Add a couple more tests... (Closed)

Created:
10 years, 8 months ago by Markus (顧孟勤)
Modified:
9 years, 7 months ago
Reviewers:
Mark Seaborn
CC:
chromium-reviews, agl
Visibility:
Public.

Description

Add a couple more tests These tests were useful for debugging reference_trusted_thread.cc. Test an easily-forwarded system call, dup(). Also test clone() directly, in addition to testing it indirectly via pthread_create(). Check for leaked FDs. Change the test runner to run all tests, even if one fails, rather than stopping at the first failed test. Review URL: http://codereview.chromium.org/1750014 BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45806

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -7 lines) Patch
M sandbox/linux/seccomp/tests/test_syscalls.cc View 7 chunks +126 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Markus (顧孟勤)
Mark, I merged your changes. Please have a quick look if this looks correct. Markus
10 years, 8 months ago (2010-04-28 01:18:07 UTC) #1
Mark Seaborn
10 years, 8 months ago (2010-04-28 12:32:26 UTC) #2
On 2010/04/28 01:18:07, Markus (顧孟勤) wrote:
> I merged your changes. Please have a quick look if this looks
> correct.

LGTM, thanks.

Powered by Google App Engine
This is Rietveld 408576698