Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 1750014: Add a couple more tests (Closed)

Created:
10 years, 8 months ago by Mark Seaborn
Modified:
9 years, 5 months ago
Reviewers:
Markus (顧孟勤)
Visibility:
Public.

Description

Add a couple more tests These tests were useful for debugging reference_trusted_thread.cc. Test an easily-forwarded system call, dup(). Also test clone() directly, in addition to testing it indirectly via pthread_create(). Check for leaked FDs. Change the test runner to run all tests, even if one fails, rather than stopping at the first failed test.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -7 lines) Patch
M tests/test_syscalls.cc View 7 chunks +123 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mark Seaborn
10 years, 8 months ago (2010-04-26 21:55:21 UTC) #1
Markus (顧孟勤)
LGTM Nitpick. Are you sure that you don't count the filedescriptors incorrectly. I would think ...
10 years, 8 months ago (2010-04-26 22:46:24 UTC) #2
Mark Seaborn
10 years, 8 months ago (2010-04-27 11:35:11 UTC) #3
On 2010/04/26 22:46:24, Markus (顧孟勤) wrote:
> LGTM
>
> Nitpick. Are you sure that you don't count the filedescriptors
> incorrectly. I would think that you need to filter out "."
> and ".."

Yes, it overcounts by 3, but that doesn't matter because it is
only used to check for differences in the number of FDs.  I've
added a comment.

Thanks,
Mark

Powered by Google App Engine
This is Rietveld 408576698