Vboot Reference: Make kernel signing utility more flexible.

Vboot Reference: Make kernel signing utility more flexible.

The CL adds the --config and --vblock option to kernel_utility.

--config <file> uses the file to populate the configuration portion within a signed vbootimage

Currently, the configuration file is assumed to only contain command line options to be passed to the kernel. In the future, we might want to change it so that it contains information about the kernel load address, entry points, etc. (refer to rspangler@ drive map design doc)

--vblock makes the tool only output the verification header instead of a one monolithic signed kernel image containing the verification information (with config information contained within it) followed by the actual kernel image

[Bill Richardson, 2010-04-26 17:54:59]

LGTM, with a couple of minor nits.

http://codereview.chromium.org/1752013/diff/1/5
File src/platform/vboot_reference/utility/kernel_utility.cc (right):

http://codereview.chromium.org/1752013/diff/1/5#newcode260
src/platform/vboot_reference/utility/kernel_utility.cc:260:
Memset(image_->options.cmd_line + len, 0,  // Fill the rest with 0x00s.
Why not just have KernelImageNew() initialize .options to all zeros?

http://codereview.chromium.org/1752013/diff/1/7
File src/platform/vboot_reference/vkernel/kernel_image.c (right):

http://codereview.chromium.org/1752013/diff/1/7#newcode330
src/platform/vboot_reference/vkernel/kernel_image.c:330: debug("Couldn't write
Kenrel Image Verification block to file: %s\n",
Typo "Kenrel"

[gauravsh, 2010-04-26 18:42:48]

Fixed and submitted, Thanks!

http://codereview.chromium.org/1752013/diff/1/5
File src/platform/vboot_reference/utility/kernel_utility.cc (right):

http://codereview.chromium.org/1752013/diff/1/5#newcode260
src/platform/vboot_reference/utility/kernel_utility.cc:260:
Memset(image_->options.cmd_line + len, 0,  // Fill the rest with 0x00s.
On 2010/04/26 17:54:59, Bill Richardson wrote:
> Why not just have KernelImageNew() initialize .options to all zeros?
> 
> 

Good idea, Done.

http://codereview.chromium.org/1752013/diff/1/7
File src/platform/vboot_reference/vkernel/kernel_image.c (right):

http://codereview.chromium.org/1752013/diff/1/7#newcode330
src/platform/vboot_reference/vkernel/kernel_image.c:330: debug("Couldn't write
Kenrel Image Verification block to file: %s\n",
On 2010/04/26 17:54:59, Bill Richardson wrote:
> Typo "Kenrel"

Done.