Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1017)

Unified Diff: src/platform/vboot_reference/utility/include/kernel_utility.h

Issue 1752013: Vboot Reference: Make kernel signing utility more flexible. (Closed)
Patch Set: review fixes Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/platform/vboot_reference/utility/include/kernel_utility.h
diff --git a/src/platform/vboot_reference/utility/include/kernel_utility.h b/src/platform/vboot_reference/utility/include/kernel_utility.h
index 1cb7f1ae501a0749b36fba1e32855621c6f4d8d7..49290f27575092a2457463a2f0b601bd8220b73c 100644
--- a/src/platform/vboot_reference/utility/include/kernel_utility.h
+++ b/src/platform/vboot_reference/utility/include/kernel_utility.h
@@ -58,6 +58,11 @@ class KernelUtility {
std::string firmware_key_pub_file_;
std::string kernel_key_file_; // Private key for signing the kernel.
std::string kernel_key_pub_file_;
+ std::string config_file_; // File containing kernel config options.
+ // TODO(gauravsh): Currently this just fills in options.cmd_line in struct
+ // KernelImage (from vkernel/kernel_image_fw.h). Ideally we'd like to have
+ // a well defined config file format which is also backwards compatible with
+ // Legacy BIOS boot loaders.
// Fields of a KernelImage. (read from the command line).
int header_version_;
@@ -66,12 +71,14 @@ class KernelUtility {
int kernel_key_version_;
int kernel_version_;
kconfig_options options_;
+ uint8_t* cmd_line_;
std::string in_file_;
std::string out_file_;
bool is_generate_; // Are we generating a new image?
bool is_verify_; // Are we just verifying an already signed image?
bool is_describe_; // Should we print out description of the image?
+ bool is_only_vblock_; // Show we just output the verification block?
};
} // namespace vboot_reference

Powered by Google App Engine
This is Rietveld 408576698