Issue 174503: Updating the script to pass the port value as part of sync-url instead of sep...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 174503: Updating the script to pass the port value as part of sync-url instead of sep... (Closed)

Created:
11 years, 4 months ago by tejasshah

Modified:
9 years, 7 months ago

Reviewers:
ncarter (slow), tim (not reviewing)

CC:
chromium-reviews_googlegroups.com, idana

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Updating the script to pass the port value as part of sync-url instead of separate parameter. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24452

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	chrome/test/live_sync/sync_integration_test.py	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tejasshah

Updating the script to pass the port value as part of sync-url .

11 years, 4 months ago (2009-08-26 03:05:07 UTC) #1

ncarter (slow)

11 years, 4 months ago (2009-08-26 03:21:24 UTC) #2

LGTM

On Tue, Aug 25, 2009 at 8:05 PM, <tejasshah@chromium.org> wrote:

> Reviewers: nick, timsteele,
>
> Message:
> Updating the script to pass the port value as part of sync-url .
>
> Description:
> Updating the script to pass the port value as part of sync-url instead
> of separate parameter.
>
> Please review this at http://codereview.chromium.org/174503
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     chrome/test/live_sync/sync_integration_test.py
>
>
> Index: chrome/test/live_sync/sync_integration_test.py
> ===================================================================
> --- chrome/test/live_sync/sync_integration_test.py      (revision 24379)
> +++ chrome/test/live_sync/sync_integration_test.py      (working copy)
> @@ -285,8 +285,7 @@
>         '--user-data-dir=' + user_dir,
>         '--sync-user-for-test=' + username,
>         '--sync-password-for-test=' + password,
> -        '--sync-url=' + HTTP_SERVER_URL,
> -        '--sync-port=' + sync_port]
> +        '--sync-url=' + HTTP_SERVER_URL + ':' + sync_port]
>     logging.info(
>         '%s will run with command: %s'
>         % (test_name, subprocess.list2cmdline(command)))
>
>
>

Expand Messages | Collapse Messages