Issue 174390: Add UMA Histogram for FieldTrial for Async Socket SlowStart...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 174390: Add UMA Histogram for FieldTrial for Async Socket SlowStart... (Closed)

Created:
11 years, 3 months ago by Mike Belshe

Modified:
9 years, 5 months ago

Reviewers:
iposva, jar (doing other things)

CC:
chromium-reviews_googlegroups.com, darin (slow to review), willchan no longer on Chromium

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add UMA Histogram for FieldTrial for Async Socket SlowStart algorithm to monitor the time between the connect and the first byte on a new connection. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24221

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -1 line)			Patch
	M	net/http/http_network_transaction.cc	View		1 chunk	+14 lines, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jar (doing other things)

11 years, 3 months ago (2009-08-25 15:51:00 UTC) #3

http://codereview.chromium.org/174390/diff/4/1002
File net/http/http_network_transaction.cc (right):

http://codereview.chromium.org/174390/diff/4/1002#newcode1263
Line 1263: UMA_HISTOGRAM_CLIPPED_TIMES(
I'd suggest using UMA_HISTOGRAM_CUSTOM_TIMES.  The comment in histogram.h notes
that CLIPPED_TIMES is deprecated, and should not be used, as it tends to make it
harder to do statistical analysis.  When creating new histograms, please
consider using CUSTOM rather than CLIPPED.  The clipped discards some data, and
it is better to be able to discard the percentage of data yuo desire, than to
have some unknown percentage not be logged.

Expand Messages | Collapse Messages