Add UMA Histogram for FieldTrial for Async Socket SlowStart...

net/http/http_network_transaction.cc

 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_network_transaction.h"
 
 #include "base/scoped_ptr.h"
 #include "base/compiler_specific.h"
 #include "base/field_trial.h"
 #include "base/histogram.h"
@@ skipping 1231 matching lines @@
 
   if (use_late_binding_histogram) {
     UMA_HISTOGRAM_CUSTOM_TIMES(
         FieldTrial::MakeName("Net.Transaction_Connected_Under_10",
                              "SocketLateBinding").data(),
         total_duration,
         base::TimeDelta::FromMilliseconds(1), base::TimeDelta::FromMinutes(10),
         100);
   }
 
-  if (!reused_socket_)
+  if (!reused_socket_) {
     UMA_HISTOGRAM_CLIPPED_TIMES(
         "Net.Transaction_Connected_New",
         total_duration,
         base::TimeDelta::FromMilliseconds(1), base::TimeDelta::FromMinutes(10),
         100);
 
+    // Also record for our field trial.
+    static bool use_async_tcp(FieldTrialList::Find("AsyncSlowStart") &&
+      !FieldTrialList::Find("AsyncSlowStart")->group_name().empty());
+    if (use_async_tcp) {
+      UMA_HISTOGRAM_CLIPPED_TIMES(

[jar (doing other things), 2009/08/25 15:51:00]

I'd suggest using UMA_HISTOGRAM_CUSTOM_TIMES.  The comment in histogram.h notes
that CLIPPED_TIMES is deprecated, and should not be used, as it tends to make it
harder to do statistical analysis.  When creating new histograms, please
consider using CUSTOM rather than CLIPPED.  The clipped discards some data, and
it is better to be able to discard the percentage of data yuo desire, than to
have some unknown percentage not be logged.

+        FieldTrial::MakeName("Net.Transaction_Connected_New",
+                             "AsyncSlowStart").data(),
+        total_duration,
+        base::TimeDelta::FromMilliseconds(1), base::TimeDelta::FromMinutes(10),
+        100);
+    }
+  }
+
   // Currently, non-zero priority requests are frame or sub-frame resource
   // types.  This will change when we also prioritize certain subresources like
   // css, js, etc.
   if (request_->priority) {
     UMA_HISTOGRAM_CLIPPED_TIMES(
         "Net.Priority_High_Latency",
         total_duration,
         base::TimeDelta::FromMilliseconds(1), base::TimeDelta::FromMinutes(10),
         100);
   } else {
@@ skipping 669 matching lines @@
     host_and_port = proxy_info_.proxy_server().host_and_port();
   } else {
     DCHECK(target == HttpAuth::AUTH_SERVER);
     host_and_port = GetHostAndPort(request_->url);
   }
   auth_info->host_and_port = ASCIIToWide(host_and_port);
   response_.auth_challenge = auth_info;
 }
 
 }  // namespace net