Update V8 to version 1.3.7....

Update V8 to version 1.3.7.

This is a minor update which contains better memory cleanup on idle
notifications.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24222

[Søren Thygesen Gjesse, 2009-08-25 08:06:07]

LGTM

[willchan no longer on Chromium, 2009-08-25 21:17:06]

I'm seeing renderer crashes after syncing to ToT this morning (pst):

Program received signal SIGABRT, Aborted.
[Switching to Thread 0xf70be6c0 (LWP 19700)]
0xffffe405 in __kernel_vsyscall ()
(gdb) ba
#0  0xffffe405 in __kernel_vsyscall ()
#1  0xf7244335 in raise () from /lib32/libc.so.6
#2  0xf7245cb1 in abort () from /lib32/libc.so.6
#3  0x09321f2f in v8::internal::OS::Abort () at v8/src/platform-linux.cc:177
#4  0x091f620e in V8_Fatal (file=0x9c24139 "v8/src/objects-inl.h",
line=1520, format=0x9c2407a "CHECK(%s) failed") at v8/src/checks.cc:56
#5  0x091d2a5a in CheckHelper (file=0x9c24139 "v8/src/objects-inl.h",
line=1520, source=0x9c243bd "object->IsSymbolTable()",
condition=false) at v8/src/checks.h:62
#6  0x091e1f03 in v8::internal::SymbolTable::cast (object=0x0) at
v8/src/objects-inl.h:1520
#7  0x091e1f1b in v8::internal::Heap::symbol_table () at v8/src/heap.h:666
#8  0x09229bec in VerifySymbolTable () at v8/src/heap.cc:431
#9  0x09229c15 in v8::internal::Heap::PerformGarbageCollection
(space=v8::internal::OLD_POINTER_SPACE,
collector=v8::internal::MARK_COMPACTOR, tracer=0xffc77958)
    at v8/src/heap.cc:453
#10 0x0922a073 in v8::internal::Heap::CollectGarbage
(requested_size=0, space=v8::internal::OLD_POINTER_SPACE) at
v8/src/heap.cc:373
#11 0x0922a22a in v8::internal::Heap::CollectAllGarbage
(force_compaction=false) at v8/src/heap.cc:323
#12 0x092d6dfa in v8::internal::Heap::IdleNotification () at v8/src/heap.h:865
#13 0x092d6a50 in v8::internal::V8::IdleNotification
(is_high_priority=false) at v8/src/v8.cc:166
#14 0x091d4e3e in v8::V8::IdleNotification (is_high_priority=false) at
v8/src/api.cc:2608
#15 0x09365f4b in RenderThread::IdleHandler (this=0xb8f1e48) at
chrome/renderer/render_thread.cc:469
#16 0x09369048 in DispatchToMethod<RenderThread, void
(RenderThread::*)()> (obj=0xb8f1e48, method=0x9365ebe
<RenderThread::IdleHandler()>, arg=@0xb93375c)
    at ./base/tuple.h:412
#17 0x09369079 in
ScopedRunnableMethodFactory<RenderThread>::RunnableMethod<void
(RenderThread::*)(), Tuple0>::Run (this=0xb933740) at
./base/task.h:197
#18 0x093690a1 in
ScopedTaskFactory<ScopedRunnableMethodFactory<RenderThread>::RunnableMethod<void
(RenderThread::*)(), Tuple0> >::TaskWrapper::Run (this=0xb933740)
    at ./base/task.h:92
#19 0x088dccce in MessageLoop::RunTask (this=0xffc78044,
task=0xb933740) at base/message_loop.cc:314
#20 0x088dd27d in MessageLoop::DeferOrRunPendingTask (this=0xffc78044,
pending_task=@0xffc77c84) at base/message_loop.cc:322
#21 0x088dd407 in MessageLoop::DoDelayedWork (this=0xffc78044,
next_delayed_work_time=0xb8f03d0) at base/message_loop.cc:456
#22 0x088e4c11 in base::MessagePumpDefault::Run (this=0xb8f03c0,
delegate=0xffc78044) at base/message_pump_default.cc:27
#23 0x088ddc3b in MessageLoop::RunInternal (this=0xffc78044) at
base/message_loop.cc:199
#24 0x088ddc55 in MessageLoop::RunHandler (this=0xffc78044) at
base/message_loop.cc:181
#25 0x088ddcf9 in MessageLoop::Run (this=0xffc78044) at base/message_loop.cc:155
#26 0x0939475d in RendererMain (parameters=@0xffc78530) at
chrome/renderer/renderer_main.cc:162
#27 0x08048ec7 in ChromeMain (argc=2, argv=0xffc786b4) at
chrome/app/chrome_dll_main.cc:548
#28 0x0804831a in main (argc=2, argv=0xffc786b4) at
chrome/app/chrome_exe_main_gtk.cc:33

I can reproduce on
http://build.chromium.org/buildbot/try-server/waterfall by just
letting the page sit idle for awhile.

I'd post a bug report on crbug.com but it's down for network maintenance.

On Tue, Aug 25, 2009 at 1:06 AM, <sgjesse@chromium.org> wrote:
>
> LGTM
>
> http://codereview.chromium.org/174389
>