Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 174179: Mock the LinkDoctor for tests. Should greatly decrease ErrorPage test flakiness. (Closed)

Created:
11 years, 4 months ago by Paweł Hajdan Jr.
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Mock the LinkDoctor for tests. Should greatly decrease ErrorPage test flakiness. TEST=Covered by ui_tests. http://crbug.com/18365, http://crbug.com/19361

Patch Set 1 #

Patch Set 2 : sync with trunk #

Patch Set 3 : sync with trunk #

Patch Set 4 : sync with trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -27 lines) Patch
M chrome/browser/errorpage_uitest.cc View 1 2 3 8 chunks +12 lines, -23 lines 0 comments Download
M chrome/browser/google_util.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/google_util.cc View 1 chunk +3 lines, -0 lines 0 comments Download
A chrome/browser/net/url_request_mock_link_doctor_job.h View 1 chunk +23 lines, -0 lines 0 comments Download
A chrome/browser/net/url_request_mock_link_doctor_job.cc View 1 chunk +40 lines, -0 lines 0 comments Download
M chrome/browser/net/url_request_mock_util.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.cc View 1 2 3 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/chrome.gyp View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/test/data/mock-link-doctor.html View 1 chunk +4 lines, -0 lines 0 comments Download
A chrome/test/data/mock-link-doctor.html.mock-http-headers View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Paweł Hajdan Jr.
11 years, 4 months ago (2009-08-20 22:01:14 UTC) #1
darin (slow to review)
11 years, 4 months ago (2009-08-20 22:17:32 UTC) #2
LGTM++

Powered by Google App Engine
This is Rietveld 408576698