Issue 174163: Print out how long presubmit checks took if it's more than 1 second.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 174163: Print out how long presubmit checks took if it's more than 1 second. (Closed)

Created:
11 years, 4 months ago by jam

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/tools/depot_tools/

Visibility:
Public.

Description

Print out how long presubmit checks took if it's more than 1 second. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23870

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	presubmit_support.py	View		3 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

good idea! %.1fs? I'm not used to python format string, I assume it prints fine. ...

11 years, 4 months ago (2009-08-20 20:23:02 UTC) #2

jam

11 years, 4 months ago (2009-08-20 20:34:46 UTC) #3

Yep:
Presubmit checks took 1.4s to calculate.

On Thu, Aug 20, 2009 at 1:23 PM, <maruel@chromium.org> wrote:

> good idea!
>
> %.1fs? I'm not used to python format string, I assume it prints fine. :)
>
>
> http://codereview.chromium.org/174163
>

Expand Messages | Collapse Messages