Linux: more interactive tests porting....

Linux: more interactive tests porting.

The most noteworthy change here is the implementation of SendMouseMove() and SendMouseClick() in ui_controls. I've combed the interwebs and I don't think it's possible to figure out the GdkWindow that is showing for a given (x,y) coordinate pair (except perhaps by delving into X), so we have to just send clicks to wherever the pointer lies. This is unfortunate in that it means we have to move the pointer, wait for it to get where it's going, and only then make the click. But on the bright side there's this super helpful function called gdk_display_warp_pointer() which makes moving the mouse a breeze.

BUG=19076
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23880

[tony, 2009-08-20 01:12:34]

http://codereview.chromium.org/174113/diff/1/6
File chrome/browser/automation/ui_controls_linux.cc (right):

http://codereview.chromium.org/174113/diff/1/6#newcode29
Line 29: NOTIMPLEMENTED() << "listening...";
Did you mean to include this?

http://codereview.chromium.org/174113/diff/1/6#newcode40
Line 40: NOTIMPLEMENTED() << "heard...";
Did you mean to include this?

http://codereview.chromium.org/174113/diff/1/5
File chrome/browser/automation/ui_controls_win.cc (right):

http://codereview.chromium.org/174113/diff/1/5#newcode40
Line 40: Task* task_;
Were we double freeing before?  Tasks get deleted automatically after running,
right?

[tony, 2009-08-20 01:14:54]

Also, LGTM

[Evan Stade, 2009-08-20 01:25:23]

http://codereview.chromium.org/174113/diff/1/6
File chrome/browser/automation/ui_controls_linux.cc (right):

http://codereview.chromium.org/174113/diff/1/6#newcode40
Line 40: NOTIMPLEMENTED() << "heard...";
On 2009/08/20 01:12:34, tony wrote:
> Did you mean to include this?

no, sorry

http://codereview.chromium.org/174113/diff/1/5
File chrome/browser/automation/ui_controls_win.cc (right):

http://codereview.chromium.org/174113/diff/1/5#newcode40
Line 40: Task* task_;
On 2009/08/20 01:12:34, tony wrote:
> Were we double freeing before?  Tasks get deleted automatically after running,
> right?

1. yes (I think)
2. yes.

[Evan Stade, 2009-08-20 01:27:31]

oh wait. They don't get deleted when you run them explicitly, only when you post
them. I need to revert that change and also use a scoped ptr on linux.

[Evan Stade, 2009-08-20 02:31:30]

updated, tanl?

[Evan Stade, 2009-08-20 02:33:25]

of course by tanl I mean TAL

(don't know why that initialization is so hard for me to get right)

-- Evan Stade



On Wed, Aug 19, 2009 at 7:31 PM, <estade@chromium.org> wrote:
> updated, tanl?
>
>
>
> http://codereview.chromium.org/174113
>

[tony, 2009-08-20 17:48:07]

Yes, LGTM.