Print more info in IsStringASCII assertions.

Print more info in IsStringASCII assertions.

This will help debugging when you have only the logs.

TEST=none
BUG=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23900

[Dean McNamee, 2009-08-20 00:22:05]

How well does our logging system dump non-ascii strings?  I guess you
just get it byte for byte in the log file?

On Wed, Aug 19, 2009 at 5:20 PM,  <phajdan.jr@chromium.org> wrote:
> Reviewers: Dean McNamee, Mark Mentovai,
>
> Description:
> Print more info in IsStringASCII assertions.
>
> This will help debugging when you have only the logs.
>
> TEST=3Dnone
> BUG=3Dnone
>
> Please review this at http://codereview.chromium.org/174110
>
> Affected files:
> =A0M base/string_util.cc
>
>
> Index: base/string_util.cc
> diff --git a/base/string_util.cc b/base/string_util.cc
> index
> b456376ee4460d10de3ecfb45fbdbb112a504fa5..f58f105ee1653b6a9ec83948d9243b3=
073c300bf
> 100644
> --- a/base/string_util.cc
> +++ b/base/string_util.cc
> @@ -502,22 +502,22 @@ std::string CollapseWhitespaceASCII(const std::stri=
ng&
> text,
> =A0}
>
> =A0std::string WideToASCII(const std::wstring& wide) {
> - =A0DCHECK(IsStringASCII(wide));
> + =A0DCHECK(IsStringASCII(wide)) << wide;
> =A0 return std::string(wide.begin(), wide.end());
> =A0}
>
> =A0std::wstring ASCIIToWide(const StringPiece& ascii) {
> - =A0DCHECK(IsStringASCII(ascii));
> + =A0DCHECK(IsStringASCII(ascii)) << ascii;
> =A0 return std::wstring(ascii.begin(), ascii.end());
> =A0}
>
> =A0std::string UTF16ToASCII(const string16& utf16) {
> - =A0DCHECK(IsStringASCII(utf16));
> + =A0DCHECK(IsStringASCII(utf16)) << utf16;
> =A0 return std::string(utf16.begin(), utf16.end());
> =A0}
>
> =A0string16 ASCIIToUTF16(const StringPiece& ascii) {
> - =A0DCHECK(IsStringASCII(ascii));
> + =A0DCHECK(IsStringASCII(ascii)) << ascii;
> =A0 return string16(ascii.begin(), ascii.end());
> =A0}
>
>
>
>

[Paweł Hajdan Jr., 2009-08-20 00:59:32]

I'm not sure, but it shouldn't crash, and will probably have some hints
about fixing the issue.

On Wed, Aug 19, 2009 at 17:21, Dean McNamee <deanm@chromium.org> wrote:

> How well does our logging system dump non-ascii strings?  I guess you
> just get it byte for byte in the log file?
>
> On Wed, Aug 19, 2009 at 5:20 PM,  <phajdan.jr@chromium.org> wrote:
> > Reviewers: Dean McNamee, Mark Mentovai,
> >
> > Description:
> > Print more info in IsStringASCII assertions.
> >
> > This will help debugging when you have only the logs.
> >
> > TEST=none
> > BUG=none
> >
> > Please review this at http://codereview.chromium.org/174110
> >
> > Affected files:
> >  M base/string_util.cc
> >
> >
> > Index: base/string_util.cc
> > diff --git a/base/string_util.cc b/base/string_util.cc
> > index
> >
>
b456376ee4460d10de3ecfb45fbdbb112a504fa5..f58f105ee1653b6a9ec83948d9243b3073c300bf
> > 100644
> > --- a/base/string_util.cc
> > +++ b/base/string_util.cc
> > @@ -502,22 +502,22 @@ std::string CollapseWhitespaceASCII(const
> std::string&
> > text,
> >  }
> >
> >  std::string WideToASCII(const std::wstring& wide) {
> > -  DCHECK(IsStringASCII(wide));
> > +  DCHECK(IsStringASCII(wide)) << wide;
> >   return std::string(wide.begin(), wide.end());
> >  }
> >
> >  std::wstring ASCIIToWide(const StringPiece& ascii) {
> > -  DCHECK(IsStringASCII(ascii));
> > +  DCHECK(IsStringASCII(ascii)) << ascii;
> >   return std::wstring(ascii.begin(), ascii.end());
> >  }
> >
> >  std::string UTF16ToASCII(const string16& utf16) {
> > -  DCHECK(IsStringASCII(utf16));
> > +  DCHECK(IsStringASCII(utf16)) << utf16;
> >   return std::string(utf16.begin(), utf16.end());
> >  }
> >
> >  string16 ASCIIToUTF16(const StringPiece& ascii) {
> > -  DCHECK(IsStringASCII(ascii));
> > +  DCHECK(IsStringASCII(ascii)) << ascii;
> >   return string16(ascii.begin(), ascii.end());
> >  }
> >
> >
> >
> >
>

[Dean McNamee, 2009-08-20 18:02:30]

Ok

On 2009/08/20 00:59:32, Paweł Hajdan Jr. wrote:
> I'm not sure, but it shouldn't crash, and will probably have some hints
> about fixing the issue.
> 
> On Wed, Aug 19, 2009 at 17:21, Dean McNamee <mailto:deanm@chromium.org> wrote:
> 
> > How well does our logging system dump non-ascii strings?  I guess you
> > just get it byte for byte in the log file?
> >
> > On Wed, Aug 19, 2009 at 5:20 PM,  <mailto:phajdan.jr@chromium.org> wrote:
> > > Reviewers: Dean McNamee, Mark Mentovai,
> > >
> > > Description:
> > > Print more info in IsStringASCII assertions.
> > >
> > > This will help debugging when you have only the logs.
> > >
> > > TEST=none
> > > BUG=none
> > >
> > > Please review this at http://codereview.chromium.org/174110
> > >
> > > Affected files:
> > >  M base/string_util.cc
> > >
> > >
> > > Index: base/string_util.cc
> > > diff --git a/base/string_util.cc b/base/string_util.cc
> > > index
> > >
> >
>
b456376ee4460d10de3ecfb45fbdbb112a504fa5..f58f105ee1653b6a9ec83948d9243b3073c300bf
> > > 100644
> > > --- a/base/string_util.cc
> > > +++ b/base/string_util.cc
> > > @@ -502,22 +502,22 @@ std::string CollapseWhitespaceASCII(const
> > std::string&
> > > text,
> > >  }
> > >
> > >  std::string WideToASCII(const std::wstring& wide) {
> > > -  DCHECK(IsStringASCII(wide));
> > > +  DCHECK(IsStringASCII(wide)) << wide;
> > >   return std::string(wide.begin(), wide.end());
> > >  }
> > >
> > >  std::wstring ASCIIToWide(const StringPiece& ascii) {
> > > -  DCHECK(IsStringASCII(ascii));
> > > +  DCHECK(IsStringASCII(ascii)) << ascii;
> > >   return std::wstring(ascii.begin(), ascii.end());
> > >  }
> > >
> > >  std::string UTF16ToASCII(const string16& utf16) {
> > > -  DCHECK(IsStringASCII(utf16));
> > > +  DCHECK(IsStringASCII(utf16)) << utf16;
> > >   return std::string(utf16.begin(), utf16.end());
> > >  }
> > >
> > >  string16 ASCIIToUTF16(const StringPiece& ascii) {
> > > -  DCHECK(IsStringASCII(ascii));
> > > +  DCHECK(IsStringASCII(ascii)) << ascii;
> > >   return string16(ascii.begin(), ascii.end());
> > >  }
> > >
> > >
> > >
> > >
> >
>