Issue 174093: Pulling new version of googleurl into the tree.

Issue 174093: Pulling new version of googleurl into the tree. (Closed)

Created:
11 years, 4 months ago by Nebojša Ćirić

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews_googlegroups.com, willchan no longer on Chromium

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Pulling new version of googleurl into the tree. Fixing a net_unittest case that wasn't updated when googleurl code was changed (but not down integrated to chrome). BUG=5490 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23965

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -6 lines)			Patch
M	DEPS	View	1 chunk	+1 line, -1 line	0 comments	Download
M	build/temp_gyp/googleurl.gyp	View	2 chunks	+1 line, -1 line	0 comments	Download
M	net/http/http_network_transaction_unittest.cc	View	1 chunk	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Nebojša Ćirić

Updating DEPS and build files for googleurl to fetch new version with IDNA bug fixes.

11 years, 4 months ago (2009-08-19 22:00:47 UTC) #1

brettw

LGTM On Wed, Aug 19, 2009 at 3:00 PM, <cira@chromium.org> wrote: > Reviewers: brettw, > ...

11 years, 4 months ago (2009-08-20 00:25:50 UTC) #2

LGTM

On Wed, Aug 19, 2009 at 3:00 PM, <cira@chromium.org> wrote:
> Reviewers: brettw,
>
> Message:
> Updating DEPS and build files for googleurl to fetch new version with
> IDNA bug fixes.
>
> Description:
> Pulling new version of googleurl into the tree.
>
> BUG=3D5490
>
>
> Please review this at http://codereview.chromium.org/174093
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
> =A0M =A0 =A0 DEPS
> =A0M =A0 =A0 build/temp_gyp/googleurl.gyp
>
>
> Index: DEPS
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- DEPS =A0 =A0 =A0 =A0(revision 23759)
> +++ DEPS =A0 =A0 =A0 =A0(working copy)
> @@ -13,7 +13,7 @@
> =A0 =A0 "/trunk/deps/support@20411",
>
> =A0 "src/googleurl":
> - =A0 =A0"http://google-url.googlecode.com/svn/trunk@110",
> + =A0 =A0"http://google-url.googlecode.com/svn/trunk@113",
>
> =A0 "src/sdch/open-vcdiff":
> =A0 =A0 "http://open-vcdiff.googlecode.com/svn/trunk@26",
> Index: build/temp_gyp/googleurl.gyp
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- build/temp_gyp/googleurl.gyp =A0 =A0 =A0 =A0(revision 23759)
> +++ build/temp_gyp/googleurl.gyp =A0 =A0 =A0 =A0(working copy)
> @@ -62,7 +62,6 @@
> =A0 =A0 =A0 'dependencies': [
> =A0 =A0 =A0 =A0 'googleurl',
> =A0 =A0 =A0 =A0 '../../testing/gtest.gyp:gtest',
> - =A0 =A0 =A0 =A0'../../testing/gtest.gyp:gtestmain',
> =A0 =A0 =A0 =A0 '../../third_party/icu38/icu38.gyp:icuuc',
> =A0 =A0 =A0 ],
> =A0 =A0 =A0 'sources': [
> @@ -71,6 +70,7 @@
> =A0 =A0 =A0 =A0 '../../googleurl/src/url_parse_unittest.cc',
> =A0 =A0 =A0 =A0 '../../googleurl/src/url_test_utils.h',
> =A0 =A0 =A0 =A0 '../../googleurl/src/url_util_unittest.cc',
> + =A0 =A0 =A0 =A0'../../googleurl/src/gurl_test_main.cc',
> =A0 =A0 =A0 ],
> =A0 =A0 },
> =A0 ],
>
>
>

Nebojša Ćirić

Brett, is there anything else I should do wrt. try bots? Mac bot says that ...

11 years, 4 months ago (2009-08-20 17:21:22 UTC) #3

Brett, is there anything else I should do wrt. try bots? Mac bot says that
one test is failing (looks related). On my local client it just works (this
case passes):

HttpNetworkTransactionTest.GetIdentifyFromUrl:
/b/slave/mac/build/src/net/http/http_network_transaction_unittest.cc:3563:
Failure
Value of: username
  Actual: L"use%00rname"
Expected: tests[i].expected_username
Which is: L"use%2500rname"
Google Test trace:
/b/slave/mac/build/src/net/http/http_network_transaction_unittest.cc:3557:
Test[3]: http://use%00rname:password@google.com
<00rname%3Apassword@google.com>


Are try bots automatically updating dependencies from DEPS & build files?

Cira

On Wed, Aug 19, 2009 at 5:25 PM, Brett Wilson <brettw@chromium.org> wrote:

> LGTM
>
> On Wed, Aug 19, 2009 at 3:00 PM, <cira@chromium.org> wrote:
> > Reviewers: brettw,
> >
> > Message:
> > Updating DEPS and build files for googleurl to fetch new version with
> > IDNA bug fixes.
> >
> > Description:
> > Pulling new version of googleurl into the tree.
> >
> > BUG=5490
> >
> >
> > Please review this at http://codereview.chromium.org/174093
> >
> > SVN Base: svn://chrome-svn/chrome/trunk/src/
> >
> > Affected files:
> >  M     DEPS
> >  M     build/temp_gyp/googleurl.gyp
> >
> >
> > Index: DEPS
> > ===================================================================
> > --- DEPS        (revision 23759)
> > +++ DEPS        (working copy)
> > @@ -13,7 +13,7 @@
> >     "/trunk/deps/support@20411",
> >
> >   "src/googleurl":
> > -    "http://google-url.googlecode.com/svn/trunk@110",
> > +    "http://google-url.googlecode.com/svn/trunk@113",
> >
> >   "src/sdch/open-vcdiff":
> >     "http://open-vcdiff.googlecode.com/svn/trunk@26",
> > Index: build/temp_gyp/googleurl.gyp
> > ===================================================================
> > --- build/temp_gyp/googleurl.gyp        (revision 23759)
> > +++ build/temp_gyp/googleurl.gyp        (working copy)
> > @@ -62,7 +62,6 @@
> >       'dependencies': [
> >         'googleurl',
> >         '../../testing/gtest.gyp:gtest',
> > -        '../../testing/gtest.gyp:gtestmain',
> >         '../../third_party/icu38/icu38.gyp:icuuc',
> >       ],
> >       'sources': [
> > @@ -71,6 +70,7 @@
> >         '../../googleurl/src/url_parse_unittest.cc',
> >         '../../googleurl/src/url_test_utils.h',
> >         '../../googleurl/src/url_util_unittest.cc',
> > +        '../../googleurl/src/gurl_test_main.cc',
> >       ],
> >     },
> >   ],
> >
> >
> >
>

Nebojša Ćirić

All three bots are failing on the same test case. I tried debugging, and %0= ...

11 years, 4 months ago (2009-08-20 17:35:13 UTC) #4

All three bots are failing on the same test case. I tried debugging, and %0=
0
does get converted into %2500 in my client. Was anything else submitted
between 110 and 113 that changed the way username is parsed? (110 is last i=
n
DEPS we have I think).
Cira

On Thu, Aug 20, 2009 at 10:20 AM, Neboj=C5=A1a =C4=86iri=C4=87 <cira@chromi=
um.org> wrote:

> Brett, is there anything else I should do wrt. try bots? Mac bot says tha=
t
> one test is failing (looks related). On my local client it just works (th=
is
> case passes):
>
> HttpNetworkTransactionTest.GetIdentifyFromUrl:
> /b/slave/mac/build/src/net/http/http_network_transaction_unittest.cc:3563=
: Failure
> Value of: username
>   Actual: L"use%00rname"
> Expected: tests[i].expected_username
> Which is: L"use%2500rname"
> Google Test trace:
> /b/slave/mac/build/src/net/http/http_network_transaction_unittest.cc:3557=
: Test[3]: http://use%00rname:password@google.com <00rname%3Apassword@googl=
e.com>
>
>
> Are try bots automatically updating dependencies from DEPS & build files?
>
> Cira
>
> On Wed, Aug 19, 2009 at 5:25 PM, Brett Wilson <brettw@chromium.org> wrote=
:
>
>> LGTM
>>
>> On Wed, Aug 19, 2009 at 3:00 PM, <cira@chromium.org> wrote:
>> > Reviewers: brettw,
>> >
>> > Message:
>> > Updating DEPS and build files for googleurl to fetch new version with
>> > IDNA bug fixes.
>> >
>> > Description:
>> > Pulling new version of googleurl into the tree.
>> >
>> > BUG=3D5490
>> >
>> >
>> > Please review this at http://codereview.chromium.org/174093
>> >
>> > SVN Base: svn://chrome-svn/chrome/trunk/src/
>> >
>> > Affected files:
>> >  M     DEPS
>> >  M     build/temp_gyp/googleurl.gyp
>> >
>> >
>> > Index: DEPS
>> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>> > --- DEPS        (revision 23759)
>> > +++ DEPS        (working copy)
>> > @@ -13,7 +13,7 @@
>> >     "/trunk/deps/support@20411",
>> >
>> >   "src/googleurl":
>> > -    "http://google-url.googlecode.com/svn/trunk@110",
>> > +    "http://google-url.googlecode.com/svn/trunk@113",
>> >
>> >   "src/sdch/open-vcdiff":
>> >     "http://open-vcdiff.googlecode.com/svn/trunk@26",
>> > Index: build/temp_gyp/googleurl.gyp
>> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>> > --- build/temp_gyp/googleurl.gyp        (revision 23759)
>> > +++ build/temp_gyp/googleurl.gyp        (working copy)
>> > @@ -62,7 +62,6 @@
>> >       'dependencies': [
>> >         'googleurl',
>> >         '../../testing/gtest.gyp:gtest',
>> > -        '../../testing/gtest.gyp:gtestmain',
>> >         '../../third_party/icu38/icu38.gyp:icuuc',
>> >       ],
>> >       'sources': [
>> > @@ -71,6 +70,7 @@
>> >         '../../googleurl/src/url_parse_unittest.cc',
>> >         '../../googleurl/src/url_test_utils.h',
>> >         '../../googleurl/src/url_util_unittest.cc',
>> > +        '../../googleurl/src/gurl_test_main.cc',
>> >       ],
>> >     },
>> >   ],
>> >
>> >
>> >
>>
>
>

Nebojša Ćirić

Added fix for net unittest to the CL. Try bots passing, but didn't test locally. ...

11 years, 4 months ago (2009-08-21 05:12:21 UTC) #5

LGTM

Expand Messages | Collapse Messages