Issue 1739015: Mac BookmarkBubbleController updateBookmarkNode crash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1739015: Mac BookmarkBubbleController updateBookmarkNode crash. (Closed)

Created:
10 years, 8 months ago by dhollowa

Modified:
9 years, 7 months ago

Reviewers:
mrossetti

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Visibility:
Public.

Description

Mac BookmarkBubbleController updateBookmarkNode crash. It is possible that due to model change the bookmark bubble window has been closed but the popup is still showing and able to notify the controller of a folder change. We ignore the sender in this case. A better fix would be to close the popup programatically, but this is not a cocoa-friendly thing to do. I recommend this fix for M5, and for M6 we revisit to close the popup. BUG=41257, 42766 TEST=Manual testing according to but report. Requires two machines. Will only crash under 10.6. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45847

Patch Set 1 #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	chrome/browser/cocoa/bookmark_bubble_controller.mm	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mrossetti

LGTM Be sure to log a bug for the follow-up and mention it here.

10 years, 8 months ago (2010-04-28 19:42:28 UTC) #2

Done.

Expand Messages | Collapse Messages