Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2154)

Unified Diff: chrome/browser/cocoa/bookmark_bubble_controller.mm

Issue 1739015: Mac BookmarkBubbleController updateBookmarkNode crash. (Closed)
Patch Set: Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/bookmark_bubble_controller.mm
diff --git a/chrome/browser/cocoa/bookmark_bubble_controller.mm b/chrome/browser/cocoa/bookmark_bubble_controller.mm
index f34fa2103256164aa0865458904e5122b74f69de..b9d56ed01e0ca4cc32e0bcff35b0de6411bac7f9 100644
--- a/chrome/browser/cocoa/bookmark_bubble_controller.mm
+++ b/chrome/browser/cocoa/bookmark_bubble_controller.mm
@@ -193,6 +193,11 @@
// handle when "choose another folder" was picked.
- (IBAction)folderChanged:(id)sender {
DCHECK([sender isEqual:folderPopUpButton_]);
+ // It is possible that due to model change our parent window has been closed
+ // but the popup is still showing and able to notify the controller of a
+ // folder change. We ignore the sender in this case.
+ if (!parentWindow_)
+ return;
NSMenuItem* selected = [folderPopUpButton_ selectedItem];
ChooseAnotherFolder* chooseItem = [[self class] chooseAnotherFolderObject];
if ([[selected representedObject] isEqual:chooseItem]) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698