Issue 1737019: Fix browser process crash in WorkerTest.WorkerContextMultiPort.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1737019: Fix browser process crash in WorkerTest.WorkerContextMultiPort. (Closed)

Created:
10 years, 8 months ago by Dmitry Titov

Modified:
9 years, 7 months ago

Reviewers:
jam, Andrew T Wilson (Slow)

CC:
chromium-reviews, Paweł Hajdan Jr., ben+cc_chromium.org

Base URL:
git://codf21.jail/chromium.git

Visibility:
Public.

Description

Fix browser process crash in WorkerTest.WorkerContextMultiPort. Also enable that test. Crash caused by using stl::map[unexisting_key] which inserts a dummy element. Added a check. BUG=42783 TEST=WorkerTest.WorkerContextMultiPort Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45875

Patch Set 1 #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	chrome/browser/worker_host/message_port_dispatcher.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
	M	chrome/worker/worker_uitest.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Dmitry Titov

Darin already has the fix for PostTask queues in WebKit, but this also fixes the ...

10 years, 8 months ago (2010-04-28 21:43:51 UTC) #1

jam

On 2010/04/28 22:30:42, John Abd-El-Malek wrote: > lgtm, nice find hmm, looks like this crashed ...

10 years, 8 months ago (2010-04-29 00:17:45 UTC) #3

Dmitry Titov

10 years, 7 months ago (2010-05-04 22:49:56 UTC) #4

On 2010/04/29 00:17:45, John Abd-El-Malek wrote:
> On 2010/04/28 22:30:42, John Abd-El-Malek wrote:
> > lgtm, nice find
> 
> hmm, looks like this crashed a few revisions after in
>
http://build.chromium.org/buildbot/waterfall/builders/Chromium%2520Linux%2520...

Yep, that is because Darin's fix was not yet in chrome, and there is also
another issue, with QueueMessage possibly coming way before OnCreate message for
message ports (current code does not expect it and has NOTREACHED in every
place).
http://codereview.chromium.org/1843003 has a fix for the latter and tries to
enable the test again.

Expand Messages | Collapse Messages