Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 1843003: Enable WorkerTest.WorkerContextMultiPort. (Closed)

Created:
10 years, 7 months ago by Dmitry Titov
Modified:
9 years, 7 months ago
CC:
chromium-reviews, jam, Paweł Hajdan Jr.
Base URL:
git://codf21.jail/chromium.git
Visibility:
Public.

Description

Enable WorkerTest.WorkerContextMultiPort. T2 more issues were fixed, PostTask is now used for WTF::callOnMainThread and MessagePort's QueueMessage IPC is queued on main thread to make sure it doesn't arrive in front of OnCreate. BUG=42783 TEST=itself Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46501

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M chrome/common/webmessageportchannel_impl.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/worker/worker_uitest.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Dmitry Titov
Another attempt. Run 200 times on release test bot: http://build.chromium.org/buildbot/try-server/builders/linux_rel/builds/7
10 years, 7 months ago (2010-05-03 22:56:07 UTC) #1
Dmitry Titov
I don't see Drew in IM for the second day, David, could you please take ...
10 years, 7 months ago (2010-05-05 20:06:25 UTC) #2
Andrew T Wilson (Slow)
I'll look at this. Don't know why you aren't seeing me in IM, though :( ...
10 years, 7 months ago (2010-05-05 20:49:55 UTC) #3
Andrew T Wilson (Slow)
10 years, 7 months ago (2010-05-05 20:51:19 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698