Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 173579: Group all JSON failures under one bug. (Closed)

Created:
11 years, 3 months ago by dglazkov
Modified:
9 years, 6 months ago
Reviewers:
jorlow
CC:
chromium-reviews_googlegroups.com, Pam (message me for reviews), darin (slow to review)
Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/
Visibility:
Public.

Description

Group all JSON failures under one bug. TBR=jorlow TEST=none BUG=14885 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24627

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M webkit/tools/layout_tests/test_expectations.txt View 5 chunks +6 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
dglazkov
11 years, 3 months ago (2009-08-27 17:53:16 UTC) #1
jorlow
11 years, 3 months ago (2009-08-27 23:33:28 UTC) #2
LGTM

On Thu, Aug 27, 2009 at 10:53 AM, <dglazkov@chromium.org> wrote:

> Reviewers: Jeremy Orlow,
>
> Description:
> Group all JSON failures under one bug.
>
> TBR=jorlow
> TEST=none
> BUG=14885
>
>
> Please review this at http://codereview.chromium.org/173579
>
> SVN Base: svn://chrome-svn.corp.google.com/chrome/trunk/src/
>
> Affected files:
>  M     webkit/tools/layout_tests/test_expectations.txt
>
>
> Index: webkit/tools/layout_tests/test_expectations.txt
> ===================================================================
> --- webkit/tools/layout_tests/test_expectations.txt     (revision 24622)
> +++ webkit/tools/layout_tests/test_expectations.txt     (working copy)
> @@ -827,6 +827,12 @@
>  BUG10279 : LayoutTests/fast/dom/Window/window-property-shadowing-name.html
> = TIMEOUT FAIL
>  BUG10279 : LayoutTests/fast/js/var-declarations-shadowing.html = FAIL
>
> +// Implement full JSON support in V8
> +BUG14885 : LayoutTests/fast/js/JSON-parse.html = FAIL
> +BUG14885 : LayoutTests/fast/js/JSON-stringify.html = FAIL TIMEOUT
> +BUG14885 : LayoutTests/fast/js/JSON-parse-reviver.html = FAIL
> +BUG14885 : LayoutTests/fast/js/JSON-stringify-replacer.html = FAIL
> +
>  // User stylesheets not currently supported by chrome.
>  // Webkit supports them by doing filesystem operations directly.
>  // This is disallowed in a sandboxed renderer. The test fails in
> @@ -2465,9 +2471,6 @@
>  // WebKit 44438:44544
>  BUG13721 LINUX :
> LayoutTests/fast/dynamic/positioned-movement-with-positioned-children.html =
> FAIL
>
> -// New test added in WebKit 44550:
> -BUG13767 : LayoutTests/fast/js/JSON-stringify.html = FAIL TIMEOUT
> -
>  BUG14207 WIN LINUX DEBUG : LayoutTests/tables/mozilla/bugs/bug28341.html =
> PASS FAIL
>
>  // Newly added test http://trac.webkit.org/changeset/44816
> @@ -2481,9 +2484,6 @@
>  BUG14832 :
> LayoutTests/editing/selection/user-drag-element-and-user-select-none.html =
> FAIL
>  BUG14831 : LayoutTests/fast/events/event-trace.html = FAIL
>
> -// WebKit 44922:44927
> -BUG14885 : LayoutTests/fast/js/JSON-parse.html = FAIL
> -
>  // WebKit 44928:44943
>  BUG14946 : LayoutTests/fast/js/date-toisostring.html = FAIL
>
> @@ -2731,7 +2731,6 @@
>  BUG18896 LINUX DEBUG :
> LayoutTests/svg/css/crash-css-generated-content.xhtml = FAIL
>
>  // Test failures from WebKit merge 46894 to 46977
> -BUG18939 : LayoutTests/fast/js/JSON-stringify-replacer.html = FAIL
>  BUG18939 : LayoutTests/fast/js/function-declaration.html = FAIL
>  BUG18939 : LayoutTests/fast/js/prototypes.html = FAIL
>  BUG18939 MAC : LayoutTests/editing/execCommand/toggle-compound-styles.html
> = FAIL
> @@ -2816,5 +2815,3 @@
>  BUG20376 WIN : LayoutTests/media/video-src-remove.html = TIMEOUT FAIL
>  BUG20377 LINUX WIN :
> LayoutTests/fast/repaint/rel-positioned-inline-with-overflow.html = FAIL
>
> -// WebKit 47810:47821
> -BUG20399 : LayoutTests/fast/js/JSON-parse-reviver.html = FAIL
>
>
>

Powered by Google App Engine
This is Rietveld 408576698