Use Arguments object in C builtins, instead of __argc__ and __argv__.

Use Arguments object in C builtins, instead of __argc__ and __argv__.
Fix a stack-offset constant.  Make Windows 64-bit stack 16-byte aligned.

Committed: http://code.google.com/p/v8/source/detail?r=2772

[William Hesse, 2009-08-27 08:36:08]

http://codereview.chromium.org/173563/diff/3/4
File src/builtins.cc (left):

http://codereview.chromium.org/173563/diff/3/4#oldcode57
Line 57: // and they evaluate to undefined values if too few arguments were
All uses of args[ ] are already guarded by checks that ensure that the index is
within the array bounds.

[Mads Ager (chromium), 2009-08-27 08:42:46]

LGTM

http://codereview.chromium.org/173563/diff/3/4
File src/builtins.cc (right):

http://codereview.chromium.org/173563/diff/3/4#newcode57
Line 57: //   args.length(): Number of arguments including the reciever.
reciever -> receiver

[Søren Thygesen Gjesse, 2009-08-27 11:18:14]

LGTM

http://codereview.chromium.org/173563/diff/12/14
File src/platform-win32.cc (right):

http://codereview.chromium.org/173563/diff/12/14#newcode1321
Line 1321: return 16;  // C math library requires the stack to be 16-byte
aligned.
Is this only for math?

[William Hesse, 2009-08-27 11:26:12]

http://codereview.chromium.org/173563/diff/12/14
File src/platform-win32.cc (right):

http://codereview.chromium.org/173563/diff/12/14#newcode1321
Line 1321: return 16;  // C math library requires the stack to be 16-byte
aligned.
On 2009/08/27 11:18:14, Søren Gjesse wrote:
> Is this only for math?
I don't know.

[Lasse Reichstein, 2009-08-27 11:35:28]

http://codereview.chromium.org/173563/diff/12/14
File src/platform-win32.cc (right):

http://codereview.chromium.org/173563/diff/12/14#newcode1321
Line 1321: return 16;  // C math library requires the stack to be 16-byte
aligned.
No, this is for all function calls in Win64.
See http://msdn.microsoft.com/en-us/library/ms235286.aspx